Skip to content
This repository has been archived by the owner on Apr 13, 2019. It is now read-only.

Fix node_count default #194

Merged
merged 2 commits into from
Mar 21, 2019
Merged

Fix node_count default #194

merged 2 commits into from
Mar 21, 2019

Conversation

rbren
Copy link
Contributor

@rbren rbren commented Mar 20, 2019

Was working with EJ and noticed that after running pentagon start-project and runner cluster_configure, the file inventory/default/clusters/$cluster/cluster-config/nodes.yml had three InstanceGroups with maxSize=minSize=3, resulting in a total of 9 nodes (3 per subnet), rather than the desired 3 nodes (1 per subnet). From what I understand, we recently switched from having one IG spread across 3 subnets, to one IG per subnet - guessing this is an artifact of that change.

Changing this default sets ig_max_size=ig_min_size=1 in inventory/default/clusters/$cluster/vars.yml, which results in maxSize=minSize=1 in nodes.yml.

Let me know if there's a better way to fix this.

@rbren rbren requested a review from ejether as a code owner March 20, 2019 16:33
@CLAassistant
Copy link

CLAassistant commented Mar 20, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@sudermanjr sudermanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to see a change where the initial maxSize is set to a higher number than 1. As it is right now, we have to make a change to enable autoscaling.

As it stands, this PR seems fine. Maybe open an issue for the rest?

@ejether
Copy link
Contributor

ejether commented Mar 21, 2019

Agreed, but I think that will be a more substantial change. @bobby-brennan woud you drop a note in the CHANGELOG.md about the change?

@rbren
Copy link
Contributor Author

rbren commented Mar 21, 2019

Done - bumped version to 3.1.2 as well.

@ejether ejether merged commit 7040c7d into master Mar 21, 2019
@ejether ejether deleted the bb/node-count-fix branch March 21, 2019 19:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants