This repository has been archived by the owner on Apr 13, 2019. It is now read-only.
fixing issue where node groups with hooks are not parsed properly #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudermanjr
reviewed
Jan 7, 2019
| for policy_type in cluster_spec.get('additionalPolicies', {}): | ||
| cluster_spec['additionalPolicies'][policy_type] = literal_unicode(cluster_spec['additionalPolicies'][policy_type]) | ||
|
|
||
| hook = yaml.load(aws_iam_kops_hook) | ||
| hook['manifest'] = literal_unicode(hook['manifest']) | ||
| cluster_spec['hooks'].append(hook) |
There was a problem hiding this comment.
I moved this to a more logical place in the code.
sudermanjr
reviewed
Jan 7, 2019
| hook['manifest'] = literal_unicode(hook['manifest']) | ||
|
|
||
| logging.debug("Removing existing kops-hook-authenticator-config.service at %d", kops_hook_index) | ||
| hooks.pop(kops_hook_index) |
There was a problem hiding this comment.
Moved the pop outside the loop so that we can actually iterate over the list properly and run the literal_unicode on the other hook manifests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.