-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shm: Introduce first support for pools #484
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisklein
reviewed
Sep 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dennisklein
reviewed
Sep 27, 2023
dennisklein
reviewed
Sep 27, 2023
dennisklein
reviewed
Sep 27, 2023
dennisklein
reviewed
Sep 27, 2023
dennisklein
reviewed
Sep 27, 2023
dennisklein
reviewed
Sep 27, 2023
28beea5
to
af9890b
Compare
dennisklein
reviewed
Sep 28, 2023
dennisklein
reviewed
Sep 28, 2023
dennisklein
reviewed
Sep 28, 2023
dennisklein
reviewed
Sep 28, 2023
dennisklein
reviewed
Sep 28, 2023
dennisklein
reviewed
Sep 28, 2023
dennisklein
reviewed
Sep 28, 2023
dennisklein
reviewed
Sep 28, 2023
dennisklein
reviewed
Sep 28, 2023
dennisklein
reviewed
Sep 29, 2023
dennisklein
reviewed
Sep 29, 2023
dennisklein
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
boost::interprocess::adaptive_pool
to store reference counts for unmanaged region buffers when these are "softly" copied by FairMQ.One additional small managed segment per unmanaged region is created to store the reference count pool. Default segment size is 10,000,000 bytes, which can be changed through regionConfig in code. RefCount object size is 2 bytes, so this should be good for up to 5 million counts.
This replaces the old functionality, which would store the ref counts as separate message objects in the main managed segment. Thus, this should reduce fragmentation of the main segment.
I also add an example that uses this, but tests are also already in place, which tested the old implementation.