Revise dependency analysis to be more precise #525
Merged
+108
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Error: This request has been automatically failed because it uses a deprecated version of |
|
@mtzguido do we need the other PR merged for this to work? if so, happy to approve it (or for you to merge it)... thanks! |
|
I think this simple patch should do it. You had very valid concerns for the other CI so maybe it can wait a bit. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency analysis was pretty coarse, and only represented dependencies from one "file" to either regular or internal headers. It turns out that the dependencies vary quite widely between that file's public header, internal header, or C implementation.
This was pointed out here: hacl-star/hacl-star#1007 (comment)
This revamps the analysis to now distinguish dependencies between { h file, internal/h file, c file } to { h file, internal/h file }.
The net result is a considerably reduced number of #includes in public headers.