-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix deployments by build outDir changed to build
and re-enabling artifact generation
#293
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, thanks for putting it all together.
Only question before approve, is that is this going to be deployed to the one and only environment for kobot? Which is essentially production?
We might want to double check with FIRST to see if it's fine to override the current legacy site if that's the case.
Long term speaking it would be great to have this CI deployed to dev or uat environment, and have a prod deploy manually triggered.
Yes, you are right. I thought about that too. It is a bit ...aggressive. Before merging, I was going to suggest a "plan B" approach that consists of:
For that purpose, I would need admin access of the repo, as I can't see how GitHub pages is set up today, if at all. |
Yes this looks like a great plan. The current site is totally static so GitHub Pages would be a good fit for deployment. It might also has the extra benefit for not being blocked by our VPN cuz I think Netlify on the other hand is blocked. For production deployment yes we can either generate artifact when a tag is generated. (aka. Alternatively, we can also have the artifact build workflow targeting |
build
What's going on?
The machine where the website is deployed is periodically checking for the existence of an
artifact.zip
file, containing abuild
folder inside, with the required assets for the deployment.A manual Github workflow has been added to trigger the release.