Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix several ldpd XML-CLI build issues #82

Merged
merged 1 commit into from
Jan 17, 2017
Merged

build: fix several ldpd XML-CLI build issues #82

merged 1 commit into from
Jan 17, 2017

Conversation

eqvinox
Copy link
Contributor

@eqvinox eqvinox commented Jan 17, 2017

  • the location of ldp_vty_cmds.c can be either in srcdir or builddir,
    depending on whether a premade file from a dist tarball is used
  • perl libxml support is only needed if that file is absent
  • the actual perl script wasn't even included in the dist tarball
  • the include location doesn't work when srcdir != builddir

Signed-off-by: David Lamparter equinox@opensourcerouting.org

@eqvinox
build: fix several ldpd XML-CLI build issues
7758fe9 
- the location of ldp_vty_cmds.c can be either in srcdir or builddir,
  depending on whether a premade file from a dist tarball is used
- perl libxml support is only needed if that file is absent
- the actual perl script wasn't even included in the dist tarball
- the include location doesn't work when srcdir != builddir

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
@eqvinox eqvinox requested a review from donaldsharp January 17, 2017 18:05
@donaldsharp
Copy link
Member

Code looks fine. I'm going to push as soon as the Test Suites complete

@donaldsharp donaldsharp merged commit 5551c07 into FRRouting:master Jan 17, 2017
@NetDEF-CI
Copy link
Collaborator

Continous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-63/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@eqvinox eqvinox deleted the queue/ldp-xml2cli-build branch January 17, 2017 20:53
cfra referenced this pull request in opensourcerouting/frr Nov 29, 2018
@rzalamena
Merge pull request #82 from LabNConsulting/working/bvl-local-vrf-nolabel
d48d891 
bgp_l3vpn_to_bgp_vrf: use FRR PR FRRouting#2053
donaldsharp pushed a commit to donaldsharp/frr that referenced this pull request Jan 21, 2021
@vivek-cumulus
bgpd: Fix and enhance 'show neighbors graceful-restart'
a8eb2df 
Ensure that the 'show bgp neighbors graceful-restart' command works for
peers in a VRF (BGP instance) as well as doesn't require the incorrect
AFI parameter.

Also, refine the code and the command output such that this is a subset
of the 'show bgp neighbors' output for the neighbor, both in the CLI
output and in JSON.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>

Testing Done:
1. Manual test with global and VRF peerings
2. precommit - job FRRouting#82 -- 2 failures are existing failures
3. bgp-min - job FRRouting#83 -- 2 failures are existing failures
donaldsharp pushed a commit to donaldsharp/frr that referenced this pull request Mar 9, 2023
@vivek-cumulus @donaldsharp
bgpd: Fix and enhance 'show neighbors graceful-restart'
40ff54c 
Ensure that the 'show bgp neighbors graceful-restart' command works for
peers in a VRF (BGP instance) as well as doesn't require the incorrect
AFI parameter.

Also, refine the code and the command output such that this is a subset
of the 'show bgp neighbors' output for the neighbor, both in the CLI
output and in JSON.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>

Testing Done:
1. Manual test with global and VRF peerings
2. precommit - job FRRouting#82 -- 2 failures are existing failures
3. bgp-min - job FRRouting#83 -- 2 failures are existing failures
donaldsharp pushed a commit to donaldsharp/frr that referenced this pull request Mar 10, 2023
@vivek-cumulus @donaldsharp
bgpd: Fix and enhance 'show neighbors graceful-restart'
2b8f03d 
Ensure that the 'show bgp neighbors graceful-restart' command works for
peers in a VRF (BGP instance) as well as doesn't require the incorrect
AFI parameter.

Also, refine the code and the command output such that this is a subset
of the 'show bgp neighbors' output for the neighbor, both in the CLI
output and in JSON.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>

Testing Done:
1. Manual test with global and VRF peerings
2. precommit - job FRRouting#82 -- 2 failures are existing failures
3. bgp-min - job FRRouting#83 -- 2 failures are existing failures
donaldsharp pushed a commit to donaldsharp/frr that referenced this pull request Mar 14, 2023
@vivek-cumulus @donaldsharp
bgpd: Fix and enhance 'show neighbors graceful-restart'
63d160b 
Ensure that the 'show bgp neighbors graceful-restart' command works for
peers in a VRF (BGP instance) as well as doesn't require the incorrect
AFI parameter.

Also, refine the code and the command output such that this is a subset
of the 'show bgp neighbors' output for the neighbor, both in the CLI
output and in JSON.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>

Testing Done:
1. Manual test with global and VRF peerings
2. precommit - job FRRouting#82 -- 2 failures are existing failures
3. bgp-min - job FRRouting#83 -- 2 failures are existing failures
donaldsharp pushed a commit to donaldsharp/frr that referenced this pull request Mar 20, 2023
@vivek-cumulus @donaldsharp
bgpd: Fix and enhance 'show neighbors graceful-restart'
22fb82f 
Ensure that the 'show bgp neighbors graceful-restart' command works for
peers in a VRF (BGP instance) as well as doesn't require the incorrect
AFI parameter.

Also, refine the code and the command output such that this is a subset
of the 'show bgp neighbors' output for the neighbor, both in the CLI
output and in JSON.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>

Testing Done:
1. Manual test with global and VRF peerings
2. precommit - job FRRouting#82 -- 2 failures are existing failures
3. bgp-min - job FRRouting#83 -- 2 failures are existing failures
donaldsharp pushed a commit to donaldsharp/frr that referenced this pull request Mar 21, 2023
@vivek-cumulus @donaldsharp
bgpd: Fix and enhance 'show neighbors graceful-restart'
a2c62d0 
Ensure that the 'show bgp neighbors graceful-restart' command works for
peers in a VRF (BGP instance) as well as doesn't require the incorrect
AFI parameter.

Also, refine the code and the command output such that this is a subset
of the 'show bgp neighbors' output for the neighbor, both in the CLI
output and in JSON.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>

Testing Done:
1. Manual test with global and VRF peerings
2. precommit - job FRRouting#82 -- 2 failures are existing failures
3. bgp-min - job FRRouting#83 -- 2 failures are existing failures
donaldsharp pushed a commit to donaldsharp/frr that referenced this pull request Mar 27, 2023
@vivek-cumulus @donaldsharp
bgpd: Fix and enhance 'show neighbors graceful-restart'
26a553b 
Ensure that the 'show bgp neighbors graceful-restart' command works for
peers in a VRF (BGP instance) as well as doesn't require the incorrect
AFI parameter.

Also, refine the code and the command output such that this is a subset
of the 'show bgp neighbors' output for the neighbor, both in the CLI
output and in JSON.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>

Testing Done:
1. Manual test with global and VRF peerings
2. precommit - job FRRouting#82 -- 2 failures are existing failures
3. bgp-min - job FRRouting#83 -- 2 failures are existing failures
donaldsharp pushed a commit to donaldsharp/frr that referenced this pull request Mar 31, 2023
@vivek-cumulus @donaldsharp
bgpd: Fix and enhance 'show neighbors graceful-restart'
af9a7ab 
Ensure that the 'show bgp neighbors graceful-restart' command works for
peers in a VRF (BGP instance) as well as doesn't require the incorrect
AFI parameter.

Also, refine the code and the command output such that this is a subset
of the 'show bgp neighbors' output for the neighbor, both in the CLI
output and in JSON.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>

Testing Done:
1. Manual test with global and VRF peerings
2. precommit - job FRRouting#82 -- 2 failures are existing failures
3. bgp-min - job FRRouting#83 -- 2 failures are existing failures
donaldsharp pushed a commit to donaldsharp/frr that referenced this pull request Dec 19, 2024
@vivek-cumulus @donaldsharp
bgpd: Fix and enhance 'show neighbors graceful-restart'
95beda3 
Ensure that the 'show bgp neighbors graceful-restart' command works for
peers in a VRF (BGP instance) as well as doesn't require the incorrect
AFI parameter.

Also, refine the code and the command output such that this is a subset
of the 'show bgp neighbors' output for the neighbor, both in the CLI
output and in JSON.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>

Testing Done:
1. Manual test with global and VRF peerings
2. precommit - job FRRouting#82 -- 2 failures are existing failures
3. bgp-min - job FRRouting#83 -- 2 failures are existing failures
donaldsharp pushed a commit to donaldsharp/frr that referenced this pull request Jan 3, 2025
@vivek-cumulus @donaldsharp
bgpd: Fix and enhance 'show neighbors graceful-restart'
f8e65f6 
Ensure that the 'show bgp neighbors graceful-restart' command works for
peers in a VRF (BGP instance) as well as doesn't require the incorrect
AFI parameter.

Also, refine the code and the command output such that this is a subset
of the 'show bgp neighbors' output for the neighbor, both in the CLI
output and in JSON.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>

Testing Done:
1. Manual test with global and VRF peerings
2. precommit - job FRRouting#82 -- 2 failures are existing failures
3. bgp-min - job FRRouting#83 -- 2 failures are existing failures
donaldsharp pushed a commit to donaldsharp/frr that referenced this pull request Jan 6, 2025
@vivek-cumulus @donaldsharp
bgpd: Fix and enhance 'show neighbors graceful-restart'
a3ed894 
Ensure that the 'show bgp neighbors graceful-restart' command works for
peers in a VRF (BGP instance) as well as doesn't require the incorrect
AFI parameter.

Also, refine the code and the command output such that this is a subset
of the 'show bgp neighbors' output for the neighbor, both in the CLI
output and in JSON.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>

Testing Done:
1. Manual test with global and VRF peerings
2. precommit - job FRRouting#82 -- 2 failures are existing failures
3. bgp-min - job FRRouting#83 -- 2 failures are existing failures
donaldsharp pushed a commit to donaldsharp/frr that referenced this pull request Jan 13, 2025
@vivek-cumulus @chiragshah6
bgpd: Fix and enhance 'show neighbors graceful-restart'
637bafc 
Ensure that the 'show bgp neighbors graceful-restart' command works for
peers in a VRF (BGP instance) as well as doesn't require the incorrect
AFI parameter.

Also, refine the code and the command output such that this is a subset
of the 'show bgp neighbors' output for the neighbor, both in the CLI
output and in JSON.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>

Testing Done:
1. Manual test with global and VRF peerings
2. precommit - job FRRouting#82 -- 2 failures are existing failures
3. bgp-min - job FRRouting#83 -- 2 failures are existing failures
donaldsharp pushed a commit to donaldsharp/frr that referenced this pull request Feb 5, 2025
@vivek-cumulus @chiragshah6
bgpd: Fix and enhance 'show neighbors graceful-restart'
38d6ad4 
Ensure that the 'show bgp neighbors graceful-restart' command works for
peers in a VRF (BGP instance) as well as doesn't require the incorrect
AFI parameter.

Also, refine the code and the command output such that this is a subset
of the 'show bgp neighbors' output for the neighbor, both in the CLI
output and in JSON.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>

Testing Done:
1. Manual test with global and VRF peerings
2. precommit - job FRRouting#82 -- 2 failures are existing failures
3. bgp-min - job FRRouting#83 -- 2 failures are existing failures
Pdoijode pushed a commit to Pdoijode/frr that referenced this pull request Mar 3, 2025
@vivek-cumulus @Pdoijode
bgpd: Fix and enhance 'show neighbors graceful-restart'
55ca80c 
Ensure that the 'show bgp neighbors graceful-restart' command works for
peers in a VRF (BGP instance) as well as doesn't require the incorrect
AFI parameter.

Also, refine the code and the command output such that this is a subset
of the 'show bgp neighbors' output for the neighbor, both in the CLI
output and in JSON.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>

Testing Done:
1. Manual test with global and VRF peerings
2. precommit - job FRRouting#82 -- 2 failures are existing failures
3. bgp-min - job FRRouting#83 -- 2 failures are existing failures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donaldsharp donaldsharp donaldsharp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eqvinox @donaldsharp @NetDEF-CI