bgpd: Rework BGP dampening to be per AFI/SAFI #5307

ton31337 · 2019-11-11T08:03:00Z

Before we had:

!
router bgp 65031
bgp dampening 1 2 3 4
!

exit2-debian-9(config)# router bgp 65031
exit2-debian-9(config-router)# address-family ipv4 multicast
exit2-debian-9(config-router-af)# bgp dampening 5 6 7 8
exit2-debian-9(config-router-af)# end
exit2-debian-9# show running-config

!
router bgp 65031
bgp dampening 1 2 3 4
!

After fix:

!
router bgp 65031
neighbor 192.168.1.2 remote-as 100
!
address-family ipv4 unicast
bgp dampening 1 2 3 4
exit-address-family
!
address-family ipv4 multicast
bgp dampening 5 6 7 8
exit-address-family
!

exit2-debian-9# show ip bgp ipv4 unicast dampening parameters
Half-life time: 1 min
Reuse penalty: 2
Suppress penalty: 3
Max suppress time: 4 min
Max suppress penalty: 32

exit2-debian-9# show ip bgp ipv4 multicast dampening parameters
Half-life time: 5 min
Reuse penalty: 6
Suppress penalty: 7
Max suppress time: 8 min
Max suppress penalty: 18

Closes #3193

Signed-off-by: Donatas Abraitis donatas.abraitis@gmail.com

Before we had: ! router bgp 65031 bgp dampening 1 2 3 4 ! exit2-debian-9(config)# router bgp 65031 exit2-debian-9(config-router)# address-family ipv4 multicast exit2-debian-9(config-router-af)# bgp dampening 5 6 7 8 exit2-debian-9(config-router-af)# end exit2-debian-9# show running-config ! router bgp 65031 bgp dampening 1 2 3 4 ! After fix: ! router bgp 65031 neighbor 192.168.1.2 remote-as 100 ! address-family ipv4 unicast bgp dampening 1 2 3 4 exit-address-family ! address-family ipv4 multicast bgp dampening 5 6 7 8 exit-address-family ! exit2-debian-9# show ip bgp ipv4 unicast dampening parameters Half-life time: 1 min Reuse penalty: 2 Suppress penalty: 3 Max suppress time: 4 min Max suppress penalty: 32 exit2-debian-9# show ip bgp ipv4 multicast dampening parameters Half-life time: 5 min Reuse penalty: 6 Suppress penalty: 7 Max suppress time: 8 min Max suppress penalty: 18 Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>

LabN-CI · 2019-11-11T08:36:34Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/5307 `a935f59`
Date	11/11/2019
Start	03:10:44
Finish	03:36:32
Run-Time	25:48
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-11-11-03:10:44.txt
Log	autoscript-2019-11-11-03:11:39.log.bz2
Memory	411 436 360

For details, please contact louberger

NetDEF-CI · 2019-11-11T10:32:24Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9652/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for bgp_route.c | 8 issues
===============================================
< WARNING: line over 80 characters
< #7887: FILE: /tmp/f1-8756/bgp_route.c:7887:
< WARNING: line over 80 characters
< #7951: FILE: /tmp/f1-8756/bgp_route.c:7951:
< WARNING: line over 80 characters
< #9297: FILE: /tmp/f1-8756/bgp_route.c:9297:
< WARNING: line over 80 characters
< #9301: FILE: /tmp/f1-8756/bgp_route.c:9301:

CLANG Static Analyzer Summary

Github Pull Request 5307, comparing to Git base SHA 26109a7

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9652/artifact/shared/static_analysis/index.html

donaldsharp · 2019-11-11T15:45:18Z

does the documenation need to be updated?

donaldsharp · 2019-11-11T16:14:30Z

Am I reading the code right? This is configuration per afi/safi. So if I have

router bgp 99
add ipv4 uni
bgp dampening ...
!
!

router bgp 99 vrf blue
add ipv4 uni
bgp dampening ....
!
!

I can only have dampening per afi/safi not per bgp instance afi safi?

ton31337 · 2019-11-11T17:12:18Z

Am I reading the code right? This is configuration per afi/safi. So if I have

router bgp 99
add ipv4 uni
bgp dampening ...
!
!

router bgp 99 vrf blue
add ipv4 uni
bgp dampening ....
!
!

I can only have dampening per afi/safi not per bgp instance afi safi?

@donaldsharp, unfortunately, this does not implement per VRF. What do you think about implementing per VRF as an enhancement with further commits?

does the documenation need to be updated?

I'll update it 👍

srimohans

Changes look good to me. No logic/functionality change except replacing the global damp variable with address family level bdc.

One thing to note, This will break the existing functionality of having the bgp dampening for BGP VRF instances.

ton31337 · 2019-11-12T11:16:44Z

@donaldsharp @srimohans actually, the previous version before this change does not work with VRF as well, neither with per AFI/SAFI, only for AFI_IP/SAFI_UNICAST. This change allows dampening work per AFI/SAFI, at least for AFI_IP/SAFI_UNICAST and AFI_IP/SAFI_MULTICAST.

LabN-CI · 2019-11-12T11:51:32Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/5307 `b7f7f0d`
Date	11/12/2019
Start	06:25:44
Finish	06:51:30
Run-Time	25:46
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-11-12-06:25:44.txt
Log	autoscript-2019-11-12-06:26:39.log.bz2
Memory	426 425 359

For details, please contact louberger

LabN-CI · 2019-11-12T13:21:41Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/5307 `3e45664`
Date	11/12/2019
Start	07:55:44
Finish	08:21:38
Run-Time	25:54
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-11-12-07:55:44.txt
Log	autoscript-2019-11-12-07:56:41.log.bz2
Memory	433 424 361

For details, please contact louberger

NetDEF-CI · 2019-11-12T14:01:05Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9669/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for bgp_route.c | 8 issues
===============================================
< WARNING: line over 80 characters
< #7887: FILE: /tmp/f1-10083/bgp_route.c:7887:
< WARNING: line over 80 characters
< #7951: FILE: /tmp/f1-10083/bgp_route.c:7951:
< WARNING: line over 80 characters
< #9297: FILE: /tmp/f1-10083/bgp_route.c:9297:
< WARNING: line over 80 characters
< #9301: FILE: /tmp/f1-10083/bgp_route.c:9301:

CLANG Static Analyzer Summary

Github Pull Request 5307, comparing to Git base SHA 26109a7

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9669/artifact/shared/static_analysis/index.html

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>

donaldsharp · 2019-11-12T15:09:54Z

agreed this is a change in behavior. I was merely asking if this behavior needed to be tracked per struct bgp -vs- an array that lives in bgp_damp.c. I'm open for suggestions.

LabN-CI · 2019-11-12T15:32:59Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/5307 `319a7d0`
Date	11/12/2019
Start	10:06:58
Finish	10:32:56
Run-Time	25:58
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-11-12-10:06:58.txt
Log	autoscript-2019-11-12-10:07:54.log.bz2
Memory	431 426 360

For details, please contact louberger

NetDEF-CI · 2019-11-12T15:47:38Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9670/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topology tests on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-9670/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2019-11-12 06:10:26,174 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:-1 



2019-11-12 06:10:26,312 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:65536 



2019-11-12 06:10:26,447 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:4294967296 



2019-11-12 06:10:26,583 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:-1:1 



2019-11-12 06:12:34,797 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 2: % Command incomplete[4]: bgp large-community-list standard Test1 permit  



2019-11-12 06:14:31,406 ERROR: assert failed at "test_bgp_multiview_topo1/test_bgp_routingTable": Routing Table verification failed for router r1, view 1:
No template matched.
template /root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/bgp_multiview_topo1/r1/show_ip_bgp_view_1-post4.1.ref: r1 failed Routing Table Check for view 1:
--- actual BGP routing table
+++ expected BGP routing table
@@ -1,4 +1,4 @@
-BGP table version is XXX, local router ID is 172.30.1.1, vrf id -
+BGP table version is XXX, local router ID is 172.30.1.1, vrf id 0
 Default local pref 100, local AS 100
 Status codes:  s suppressed, d damped, h history, * valid, > best, = multipath,
                i internal, r RIB-failure, S Stale, R Removed
template /root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/bgp_multiview_topo1/r1/show_ip_bgp_view_1.ref: r1 failed Routing Table Check for view 1:
--- actual BGP routing table
+++ expected BGP routing table
@@ -1,4 +1,4 @@
-BGP table version is XXX, local router ID is 172.30.1.1, vrf id -
+BGP table version is XXX, local router ID is 172.30.1.1, vrf id 0
 Default local pref 100, local AS 100
 Status codes:  s suppressed, d damped, h history, * valid, > best, = multipath,
                i internal, r RIB-failure, S Stale, R Removed
template /root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/bgp_multiview_topo1/r1/show_ip_bgp_view_1-post6.1.ref: r1 failed Routing Table Check for view 1:
--- actual BGP routing table
+++ expected BGP routing table
@@ -1,4 +1,4 @@
-BGP table version is XXX, local router ID is 172.30.1.1, vrf id -
+BGP table version is XXX, local router ID is 172.30.1.1, vrf id 0
 Default local pref 100, local AS 100
 Status codes:  s suppressed, d damped, h history, * valid, > best, = multipath,
                i internal, r RIB-failure, S Stale, R Removed

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9670/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topotest tests on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-9670/test

Topology Tests failed for Topotest tests on Ubuntu 16.04 i386:

RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
*** defaultIntf: warning: r1 has no interfaces
2019-11-12 06:11:58,239 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:-1 



2019-11-12 06:11:58,380 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:65536 



2019-11-12 06:11:58,538 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:4294967296 



2019-11-12 06:11:58,705 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:-1:1 



2019-11-12 06:13:59,687 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 2: % Command incomplete[4]: bgp large-community-list standard Test1 permit  



2019-11-12 06:16:00,820 ERROR: assert failed at "test_bgp_multiview_topo1/test_bgp_routingTable": Routing Table verification failed for router r1, view 1:
No template matched.
template /root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/bgp_multiview_topo1/r1/show_ip_bgp_view_1.ref: r1 failed Routing Table Check for view 1:
--- actual BGP routing table
+++ expected BGP routing table
@@ -1,4 +1,4 @@
-BGP table version is XXX, local router ID is 172.30.1.1, vrf id -
+BGP table version is XXX, local router ID is 172.30.1.1, vrf id 0
 Default local pref 100, local AS 100
 Status codes:  s suppressed, d damped, h history, * valid, > best, = multipath,
                i internal, r RIB-failure, S Stale, R Removed
template /root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/bgp_multiview_topo1/r1/show_ip_bgp_view_1-post4.1.ref: r1 failed Routing Table Check for view 1:
--- actual BGP routing table
+++ expected BGP routing table
@@ -1,4 +1,4 @@
-BGP table version is XXX, local router ID is 172.30.1.1, vrf id -
+BGP table version is XXX, local router ID is 172.30.1.1, vrf id 0
 Default local pref 100, local AS 100
 Status codes:  s suppressed, d damped, h history, * valid, > best, = multipath,
                i internal, r RIB-failure, S Stale, R Removed
template /root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/bgp_multiview_topo1/r1/show_ip_bgp_view_1-post6.1.ref: r1 failed Routing Table Check for view 1:
--- actual BGP routing table
+++ expected BGP routing table
@@ -1,4 +1,4 @@
-BGP table version is XXX, local router ID is 172.30.1.1, vrf id -
+BGP table version is XXX, local router ID is 172.30.1.1, vrf id 0
 Default local pref 100, local AS 100
 Status codes:  s suppressed, d damped, h history, * valid, > best, = multipath,
                i internal, r RIB-failure, S Stale, R Removed

RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9670/artifact/TOPOI386/ErrorLog/log_topotests.txt

Topology tests on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-9670/test

Topology Tests failed for Topology tests on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2019-11-12 14:10:12,409 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:-1 



2019-11-12 14:10:12,523 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:65536 



2019-11-12 14:10:12,630 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:4294967296 



2019-11-12 14:10:12,734 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:-1:1 



2019-11-12 14:12:08,877 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 2: % Command incomplete[4]: bgp large-community-list standard Test1 permit  



2019-11-12 14:14:02,596 ERROR: assert failed at "test_bgp_multiview_topo1/test_bgp_routingTable": Routing Table verification failed for router r1, view 1:
No template matched.
template /root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/bgp_multiview_topo1/r1/show_ip_bgp_view_1-post6.1.ref: r1 failed Routing Table Check for view 1:
--- actual BGP routing table
+++ expected BGP routing table
@@ -1,4 +1,4 @@
-BGP table version is XXX, local router ID is 172.30.1.1, vrf id -
+BGP table version is XXX, local router ID is 172.30.1.1, vrf id 0
 Default local pref 100, local AS 100
 Status codes:  s suppressed, d damped, h history, * valid, > best, = multipath,
                i internal, r RIB-failure, S Stale, R Removed
template /root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/bgp_multiview_topo1/r1/show_ip_bgp_view_1.ref: r1 failed Routing Table Check for view 1:
--- actual BGP routing table
+++ expected BGP routing table
@@ -1,4 +1,4 @@
-BGP table version is XXX, local router ID is 172.30.1.1, vrf id -
+BGP table version is XXX, local router ID is 172.30.1.1, vrf id 0
 Default local pref 100, local AS 100
 Status codes:  s suppressed, d damped, h history, * valid, > best, = multipath,
                i internal, r RIB-failure, S Stale, R Removed
template /root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/bgp_multiview_topo1/r1/show_ip_bgp_view_1-post4.1.ref: r1 failed Routing Table Check for view 1:
--- actual BGP routing table
+++ expected BGP routing table
@@ -1,4 +1,4 @@
-BGP table version is XXX, local router ID is 172.30.1.1, vrf id -
+BGP table version is XXX, local router ID is 172.30.1.1, vrf id 0
 Default local pref 100, local AS 100
 Status codes:  s suppressed, d damped, h history, * valid, > best, = multipath,
                i internal, r RIB-failure, S Stale, R Removed

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9670/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Successful on other platforms

Addresssanitizer topotest
Debian 8 deb pkg check
Debian 9 deb pkg check
IPv4 protocols on Ubuntu 14.04
IPv4 ldp protocol on Ubuntu 16.04
Ubuntu 14.04 deb pkg check
Static analyzer (clang)
CentOS 7 rpm pkg check
IPv6 protocols on Ubuntu 14.04
Debian 10 deb pkg check
Ubuntu 16.04 deb pkg check
Ubuntu 12.04 deb pkg check
Fedora 29 rpm pkg check

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9670/artifact/TOPOU1604/MemoryLeaks/
Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9670/artifact/TOPOI386/MemoryLeaks/
Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9670/artifact/TOPOU1804/MemoryLeaks/

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topology tests on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-9670/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2019-11-12 06:10:26,174 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:-1 



2019-11-12 06:10:26,312 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:65536 



2019-11-12 06:10:26,447 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:4294967296 



2019-11-12 06:10:26,583 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:-1:1 



2019-11-12 06:12:34,797 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 2: % Command incomplete[4]: bgp large-community-list standard Test1 permit  



2019-11-12 06:14:31,406 ERROR: assert failed at "test_bgp_multiview_topo1/test_bgp_routingTable": Routing Table verification failed for router r1, view 1:
No template matched.
template /root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/bgp_multiview_topo1/r1/show_ip_bgp_view_1-post4.1.ref: r1 failed Routing Table Check for view 1:
--- actual BGP routing table
+++ expected BGP routing table
@@ -1,4 +1,4 @@
-BGP table version is XXX, local router ID is 172.30.1.1, vrf id -
+BGP table version is XXX, local router ID is 172.30.1.1, vrf id 0
 Default local pref 100, local AS 100
 Status codes:  s suppressed, d damped, h history, * valid, > best, = multipath,
                i internal, r RIB-failure, S Stale, R Removed
template /root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/bgp_multiview_topo1/r1/show_ip_bgp_view_1.ref: r1 failed Routing Table Check for view 1:
--- actual BGP routing table
+++ expected BGP routing table
@@ -1,4 +1,4 @@
-BGP table version is XXX, local router ID is 172.30.1.1, vrf id -
+BGP table version is XXX, local router ID is 172.30.1.1, vrf id 0
 Default local pref 100, local AS 100
 Status codes:  s suppressed, d damped, h history, * valid, > best, = multipath,
                i internal, r RIB-failure, S Stale, R Removed
template /root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/bgp_multiview_topo1/r1/show_ip_bgp_view_1-post6.1.ref: r1 failed Routing Table Check for view 1:
--- actual BGP routing table
+++ expected BGP routing table
@@ -1,4 +1,4 @@
-BGP table version is XXX, local router ID is 172.30.1.1, vrf id -
+BGP table version is XXX, local router ID is 172.30.1.1, vrf id 0
 Default local pref 100, local AS 100
 Status codes:  s suppressed, d damped, h history, * valid, > best, = multipath,
                i internal, r RIB-failure, S Stale, R Removed

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9670/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topotest tests on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-9670/test

Topology Tests failed for Topotest tests on Ubuntu 16.04 i386:

RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
*** defaultIntf: warning: r1 has no interfaces
2019-11-12 06:11:58,239 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:-1 



2019-11-12 06:11:58,380 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:65536 



2019-11-12 06:11:58,538 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:4294967296 



2019-11-12 06:11:58,705 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:-1:1 



2019-11-12 06:13:59,687 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 2: % Command incomplete[4]: bgp large-community-list standard Test1 permit  



2019-11-12 06:16:00,820 ERROR: assert failed at "test_bgp_multiview_topo1/test_bgp_routingTable": Routing Table verification failed for router r1, view 1:
No template matched.
template /root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/bgp_multiview_topo1/r1/show_ip_bgp_view_1.ref: r1 failed Routing Table Check for view 1:
--- actual BGP routing table
+++ expected BGP routing table
@@ -1,4 +1,4 @@
-BGP table version is XXX, local router ID is 172.30.1.1, vrf id -
+BGP table version is XXX, local router ID is 172.30.1.1, vrf id 0
 Default local pref 100, local AS 100
 Status codes:  s suppressed, d damped, h history, * valid, > best, = multipath,
                i internal, r RIB-failure, S Stale, R Removed
template /root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/bgp_multiview_topo1/r1/show_ip_bgp_view_1-post4.1.ref: r1 failed Routing Table Check for view 1:
--- actual BGP routing table
+++ expected BGP routing table
@@ -1,4 +1,4 @@
-BGP table version is XXX, local router ID is 172.30.1.1, vrf id -
+BGP table version is XXX, local router ID is 172.30.1.1, vrf id 0
 Default local pref 100, local AS 100
 Status codes:  s suppressed, d damped, h history, * valid, > best, = multipath,
                i internal, r RIB-failure, S Stale, R Removed
template /root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/bgp_multiview_topo1/r1/show_ip_bgp_view_1-post6.1.ref: r1 failed Routing Table Check for view 1:
--- actual BGP routing table
+++ expected BGP routing table
@@ -1,4 +1,4 @@
-BGP table version is XXX, local router ID is 172.30.1.1, vrf id -
+BGP table version is XXX, local router ID is 172.30.1.1, vrf id 0
 Default local pref 100, local AS 100
 Status codes:  s suppressed, d damped, h history, * valid, > best, = multipath,
                i internal, r RIB-failure, S Stale, R Removed

RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9670/artifact/TOPOI386/ErrorLog/log_topotests.txt

Topology tests on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-9670/test

Topology Tests failed for Topology tests on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2019-11-12 14:10:12,409 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:-1 



2019-11-12 14:10:12,523 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:65536 



2019-11-12 14:10:12,630 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:4294967296 



2019-11-12 14:10:12,734 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:-1:1 



2019-11-12 14:12:08,877 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 1505, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 235, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 380, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 2: % Command incomplete[4]: bgp large-community-list standard Test1 permit  



2019-11-12 14:14:02,596 ERROR: assert failed at "test_bgp_multiview_topo1/test_bgp_routingTable": Routing Table verification failed for router r1, view 1:
No template matched.
template /root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/bgp_multiview_topo1/r1/show_ip_bgp_view_1-post6.1.ref: r1 failed Routing Table Check for view 1:
--- actual BGP routing table
+++ expected BGP routing table
@@ -1,4 +1,4 @@
-BGP table version is XXX, local router ID is 172.30.1.1, vrf id -
+BGP table version is XXX, local router ID is 172.30.1.1, vrf id 0
 Default local pref 100, local AS 100
 Status codes:  s suppressed, d damped, h history, * valid, > best, = multipath,
                i internal, r RIB-failure, S Stale, R Removed
template /root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/bgp_multiview_topo1/r1/show_ip_bgp_view_1.ref: r1 failed Routing Table Check for view 1:
--- actual BGP routing table
+++ expected BGP routing table
@@ -1,4 +1,4 @@
-BGP table version is XXX, local router ID is 172.30.1.1, vrf id -
+BGP table version is XXX, local router ID is 172.30.1.1, vrf id 0
 Default local pref 100, local AS 100
 Status codes:  s suppressed, d damped, h history, * valid, > best, = multipath,
                i internal, r RIB-failure, S Stale, R Removed
template /root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/bgp_multiview_topo1/r1/show_ip_bgp_view_1-post4.1.ref: r1 failed Routing Table Check for view 1:
--- actual BGP routing table
+++ expected BGP routing table
@@ -1,4 +1,4 @@
-BGP table version is XXX, local router ID is 172.30.1.1, vrf id -
+BGP table version is XXX, local router ID is 172.30.1.1, vrf id 0
 Default local pref 100, local AS 100
 Status codes:  s suppressed, d damped, h history, * valid, > best, = multipath,
                i internal, r RIB-failure, S Stale, R Removed

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9670/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Report for bgp_route.c | 8 issues
===============================================
< WARNING: line over 80 characters
< #7887: FILE: /tmp/f1-31291/bgp_route.c:7887:
< WARNING: line over 80 characters
< #7951: FILE: /tmp/f1-31291/bgp_route.c:7951:
< WARNING: line over 80 characters
< #9297: FILE: /tmp/f1-31291/bgp_route.c:9297:
< WARNING: line over 80 characters
< #9301: FILE: /tmp/f1-31291/bgp_route.c:9301:

CLANG Static Analyzer Summary

Github Pull Request 5307, comparing to Git base SHA 26109a7

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9670/artifact/shared/static_analysis/index.html

NetDEF-CI · 2019-11-12T17:06:18Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9674/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for bgp_route.c | 8 issues
===============================================
< WARNING: line over 80 characters
< #7887: FILE: /tmp/f1-30392/bgp_route.c:7887:
< WARNING: line over 80 characters
< #7951: FILE: /tmp/f1-30392/bgp_route.c:7951:
< WARNING: line over 80 characters
< #9297: FILE: /tmp/f1-30392/bgp_route.c:9297:
< WARNING: line over 80 characters
< #9301: FILE: /tmp/f1-30392/bgp_route.c:9301:

CLANG Static Analyzer Summary

Github Pull Request 5307, comparing to Git base SHA 1deb86b

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9674/artifact/shared/static_analysis/index.html

polychaeta added the bgp label Nov 11, 2019

srimohans approved these changes Nov 11, 2019

View reviewed changes

bisdhdh approved these changes Nov 12, 2019

View reviewed changes

doc: Append documentation for bgp dampening command

319a7d0

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>

donaldsharp merged commit a6ac9df into FRRouting:master Nov 12, 2019

ton31337 deleted the fix/bgp_dampening_per_afi_safi branch November 12, 2019 20:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bgpd: Rework BGP dampening to be per AFI/SAFI #5307

bgpd: Rework BGP dampening to be per AFI/SAFI #5307

ton31337 commented Nov 11, 2019

LabN-CI commented Nov 11, 2019

NetDEF-CI commented Nov 11, 2019

donaldsharp commented Nov 11, 2019

donaldsharp commented Nov 11, 2019

ton31337 commented Nov 11, 2019

srimohans left a comment

ton31337 commented Nov 12, 2019

LabN-CI commented Nov 12, 2019

LabN-CI commented Nov 12, 2019

NetDEF-CI commented Nov 12, 2019

donaldsharp commented Nov 12, 2019

LabN-CI commented Nov 12, 2019

NetDEF-CI commented Nov 12, 2019

NetDEF-CI commented Nov 12, 2019

bgpd: Rework BGP dampening to be per AFI/SAFI #5307

bgpd: Rework BGP dampening to be per AFI/SAFI #5307

Conversation

ton31337 commented Nov 11, 2019

LabN-CI commented Nov 11, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Nov 11, 2019

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

donaldsharp commented Nov 11, 2019

donaldsharp commented Nov 11, 2019

ton31337 commented Nov 11, 2019

srimohans left a comment

Choose a reason for hiding this comment

ton31337 commented Nov 12, 2019

LabN-CI commented Nov 12, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

LabN-CI commented Nov 12, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Nov 12, 2019

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

donaldsharp commented Nov 12, 2019

LabN-CI commented Nov 12, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Nov 12, 2019

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

NetDEF-CI commented Nov 12, 2019

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.