Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ldpd tshoot #286

Merged
merged 4 commits into from
Mar 24, 2017
Merged

Ldpd tshoot #286

merged 4 commits into from
Mar 24, 2017

Conversation

rwestphal
Copy link
Member

This patchset adds a few more "show" commands to ldpd and extend some existing commands to provide more detailed information. This should facilitate the process of troubleshooting ldpd in production networks. When things are not working, the more information you can get the better.

donaldsharp
donaldsharp reviewed Mar 20, 2017
View reviewed changes
ldpd/ldp_vty_exec.c Outdated
log_label(rt->local_label));
json_object_string_add(json_lib_entry, "remoteLabel",
log_label(rt->remote_label));
json_object_string_add(json_lib_entry, "inUse",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a integer?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that would be better I think. Will update in a few minutes.

@NetDEF-CI
Copy link
Collaborator

Continous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-378/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Successful

Basic Tests: Failed

IPv4 ldp protocol on Ubuntu 16.04: Successful
Static analyzer (clang): Successful
IPv6 protocols on Ubuntu 14.04: Successful
IPv4 protocols on Ubuntu 14.04: Successful

Topology tests on Ubuntu 16.04: Failed

Topology tests on Ubuntu 16.04: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-378/artifact/TOPOU1604/ErrorLog/
Topology tests on Ubuntu 16.04: No useful log found

@rwestphal
ldpd: provide both a brief and a detailed version of some show commands
bc0eb28 
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
@rwestphal
ldpd: add commands to show sent/rcvd capabilities
99cfc17 
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
@rwestphal
ldpd: change the sorting algorithm of adjacencies
f272562 
Now the "show mpls ldp discovery" command will display all LDP
adjancencies sorted by address family, neighbor ID and then type (link
or targeted).

Example:
vtysh# show mpls ldp discovery
AF   ID              Type     Source           Holdtime
ipv4 3.3.3.3         Link     rt2-eth1               15
ipv4 3.3.3.3         Link     rt2-eth2               15
ipv4 4.4.4.4         Link     rt2-eth1               15
ipv6 1.1.1.1         Link     rt2-eth0               15
ipv6 3.3.3.3         Link     rt2-eth1               15
ipv6 3.3.3.3         Link     rt2-eth2               15
ipv6 4.4.4.4         Link     rt2-eth1               15

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
@rwestphal
ldpd: provide more detailed information in some show commands
0f7b5df 
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
@rwestphal
Copy link
Member Author

Topology tests on Ubuntu 16.04: Failed
^
This failure was expected as this PR changed the output of several ldpd "show" commands. Once this is merged I'll ask @mwinter-osr to update his scripts to account for these changes.

@NetDEF-CI
Copy link
Collaborator

Continous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-379/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Successful

Basic Tests: Failed

Static analyzer (clang): Successful
IPv4 protocols on Ubuntu 14.04: Successful
IPv6 protocols on Ubuntu 14.04: Successful
IPv4 ldp protocol on Ubuntu 16.04: Successful

Topology tests on Ubuntu 16.04: Failed

Topology tests on Ubuntu 16.04: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-379/artifact/TOPOU1604/ErrorLog/
Topology tests on Ubuntu 16.04: No useful log found

@mwinter-osr
Copy link
Member

I believe there is an error in the "show mpls ldp neighbor" output.

Using the Topotests, for R1, the output was like this before:

Peer LDP Identifier: 2.2.2.2:0
  TCP connection: 1.1.1.1:xxx - 2.2.2.2:xxx
  Session Holdtime: 180 sec
  State: OPERATIONAL; Downstream-Unsolicited
  Up time: xx:xx:xx
  LDP Discovery Sources:
	IPv4:
	  Interface: r1-eth0

Now with this change, I get:

AF   ID              State       Remote Address    Uptime

--> no neighbor shows up. This looks wrong to me..

@rwestphal
Copy link
Member Author

rwestphal commented Mar 23, 2017 •
edited
Loading

Now by default ldpd will display a "terse" output in the show commands, and if you want more detailed information you have to use the detail option.

Example:

ubuntu# show mpls ldp neighbor 
AF   ID              State       Remote Address    Uptime
ipv4 1.1.1.1         OPERATIONAL 1.1.1.1         00:00:08
ipv4 3.3.3.3         OPERATIONAL 3.3.3.3         00:00:13
ipv4 4.4.4.4         OPERATIONAL 4.4.4.4         00:00:13

ubuntu# show mpls ldp neighbor detail
Peer LDP Identifier: 1.1.1.1:0
  TCP connection: 2.2.2.2:38676 - 1.1.1.1:646
  Authentication: none
  Session Holdtime: 180 secs; KeepAlive interval: 60 secs
  State: OPERATIONAL; Downstream-Unsolicited
  Up time: 00:00:23
  Messages sent/rcvd:
   - Keepalive Messages: 1/1
   - Address Messages: 1/1
   - Address Withdraw Messages: 0/0
   - Notification Messages: 0/0
   - Capability Messages: 0/0
   - Label Mapping Messages: 7/7
   - Label Request Messages: 0/0
   - Label Withdraw Messages: 0/0
   - Label Release Messages: 0/0
   - Label Abort Request Messages: 0/0
  Capabilities Sent:
   - Dynamic Announcement (0x0506)
   - Typed Wildcard (0x050B)
   - Unrecognized Notification (0x0603)
  Capabilities Received:
   - Dynamic Announcement (0x0506)
   - Typed Wildcard (0x050B)
   - Unrecognized Notification (0x0603)
  LDP Discovery Sources:
    IPv4:
      Interface: rt2-eth0
(...)

With that said, are you sure you waited long enough for the neighborships to come up?

@mwinter-osr
Copy link
Member

Yes, code change required for waiting to get LDP converged. "show mpls ldp neighbor" changed and now falsely triggered a converged in the script, even when it didn't.
Ignore my prev comment

@mwinter-osr
Copy link
Member

Topotests updated - triggering new testrun of this PR

@NetDEF-CI
Copy link
Collaborator

Continous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-390/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@donaldsharp donaldsharp merged commit 7bd4897 into FRRouting:master Mar 24, 2017
@eqvinox eqvinox deleted the ldpd-tshoot branch March 25, 2017 09:47
@qlyoung qlyoung mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donaldsharp donaldsharp donaldsharp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rwestphal @NetDEF-CI @mwinter-osr @donaldsharp