bug fixes #266
Merged
bug fixes #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zebra when it was scanning the tree would unset NEXTHOPS_CHANGED after the first notification. If the route we are notifying because of covers multiple interesting nexthops then we would be unable to know that we need to notify for that one as well because of the flag removal. Ticket: CM-15157 Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Continous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-355/ This is a comment from an EXPERIMENTAL automated CI system. |
Suppose we are handling the process_workq and either a new static route is installed or a Routing Protocol installs a new route. We will call evaluate_rnh with a specific prefix. We might have a situation where we clear the NHC flag prematurely. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Continous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-357/ This is a comment from an EXPERIMENTAL automated CI system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow nht in zebra to notify more than one nexthop that is being tracked when they are covered under the same prefix
Cherry-pick the Frr.conf -> frr.conf so that we are the same between master and stable