Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: handle case specifc types, protect against double free (issue #144) #265

Closed
wants to merge 1 commit into from
Closed

lib: handle case specifc types, protect against double free (issue #144) #265

wants to merge 1 commit into from

Conversation

louberger
Copy link
Member

This fixes issue #144

@NetDEF-CI
Copy link
Collaborator

Continous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-350/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@eqvinox
Copy link
Contributor

eqvinox commented Mar 8, 2017

argh... i didn't notice the return value from cmd_complete_command_real() is allocated from different counting pools depending on what path is taken...

can we fix this differently by making the return value always be allocated from the same pool? probably MTYPE_TMP?

@eqvinox
Copy link
Contributor

eqvinox commented Mar 9, 2017

correct fix is actually to revert 039dc61
(plus the two "= NULL" lines you added)

@eqvinox
Copy link
Contributor

eqvinox commented Mar 9, 2017

=> #267

@eqvinox
Copy link
Contributor

eqvinox commented Mar 9, 2017

replaced by #267 which is merged - closing

@eqvinox eqvinox closed this Mar 9, 2017
@qlyoung qlyoung mentioned this pull request Dec 20, 2017
Merged
@louberger louberger deleted the working/2.0/patch-144 branch February 9, 2018 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@louberger @NetDEF-CI @eqvinox