Coverity #183
Coverity #183
Conversation
Calling zapi_ipv[4|6]_route assumes we set the instance appropriately. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
dn_flag was tested inside of a 'use_json' block further down in the function. Move initialization of the value to outside of the !use_json if statement Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Cleanup the in_ifname and out_ifname buffers to be large enough to hold the actual interface names. Additionally move the common variables to be defined once, instead of inside of multiple for loops Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Don't leak a socket when we are unable to set it as non-blocking and warn the user as appropriate. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
bgpd/bgp_vty.c
Outdated
| memset(dn_flag, '\0', sizeof(dn_flag)); | ||
| if (peer_dynamic_neighbor(p)) | ||
| dn_flag[0] = '*'; | ||
|
|
||
| vty_out (vty, "BGP neighbor is %s%s, ", dn_flag, p->host); |
There was a problem hiding this comment.
Need to remove 2 spaces of indent here :)
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Continous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-236/ This is a comment from an EXPERIMENTAL automated CI system. |
Continous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-238/ This is a comment from an EXPERIMENTAL automated CI system. |
No description provided.