Revert "bgpd: fix default instance when leaving the hidden state (backport 10.3)" #18162 #18255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is this a revert? |
@ton31337 I added a comment above. |
|
hold on. I am providing a fix |
louis-6wind
suggested changes
Feb 25, 2025
This reverts commit 85c5598. Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>
This reverts commit bb79a65. Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>
This reverts commit 8e04277. Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>
This reverts commit d9d74d3. Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>
This reverts commit a2c1956. Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>
This reverts commit 2066493. Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>
c8c2c69 to
c2ecbdc
Compare
louis-6wind
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #18162 is a backport of #18119. The backport was merged assuming the original PR (#18119 ) has been merged. But that is not the case. I still see activity and fixes going in the original PR. Furthermore, dev/10.3 now fails CI.