fabricd: add option to treat dummy interfaces as loopback interfaces #18242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
324982e to
f2cdb7a
Compare
|
can we separate out the zebra code changes to their own commit? It's a bit of logical code that is needed but not actually part of the fabricd changes. I would prefer that the code is broken up this way to allow for future understanding |
Introduce ZEBRA_IF_DUMMY interface flag to identify Linux dummy interfaces [0]. These interfaces behave similarly to loopback interfaces and can be specially handled by daemons. [0]: https://github.com/torvalds/linux/blob/master/drivers/net/dummy.c Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
|
done @donaldsharp. Let me know if there is anything else you need. |
riw777
approved these changes
Feb 25, 2025
|
Enable dummy-interfaces to be used as router-id interfaces in openfabric networks. This allows multiple openfabric routers with different router-ids on a single node when using IP unnumbered setup (interfaces without IPs configured). Previously we were limited by having a single loopback interface, allowing only one openfabric router per node. Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
|
Thanks for the review @riw777! Fixed the style issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add interface status flag for interfaces of type "dummy" 0. Add fabricd option to treat dummy interfaces as loopback interfaces.
This is a (kind of) continuation of #10679.
This patch enables dummy-interfaces to be used as router-id interfaces in openfabric networks. This allows us to have multiple openfabric routers with different router-id's on a single node when using a ip unnumbered setup (interfaces without ip's configured). Previously we were limited by only having a single loopback interface, meaning only a single openfabric router was possible.