bgpd: release manual vpn label on instance deletion #18121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a BGP instance with a manually assigned VPN label is deleted, the label is not released from the Zebra label registry. As a result, reapplying a configuration with the same manual label leads to VPN prefix export failures. For example, with the following configuration: > router bgp 65000 vrf BLUE > address-family ipv4 unicast > label vpn export <int> Release zebra label registry on unconfiguration. Fixes: d162d5f ("bgpd: fix hardset l3vpn label available in mpls pool") Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
|
@Mergifyio backport dev/10.3 stable/10.2 stable/10.1 stable/10.0 |
✅ Backports have been created
|
This was referenced Feb 13, 2025
donaldsharp
added a commit
that referenced
this pull request
Feb 13, 2025
bgpd: release manual vpn label on instance deletion (backport #18121)
riw777
added a commit
that referenced
this pull request
Feb 18, 2025
bgpd: release manual vpn label on instance deletion (backport #18121)
riw777
added a commit
that referenced
this pull request
Feb 18, 2025
bgpd: release manual vpn label on instance deletion (backport #18121)
riw777
added a commit
that referenced
this pull request
Feb 18, 2025
bgpd: release manual vpn label on instance deletion (backport #18121)
donaldsharp
added a commit
that referenced
this pull request
Feb 19, 2025
donaldsharp
added a commit
that referenced
this pull request
Feb 19, 2025
donaldsharp
added a commit
that referenced
this pull request
Feb 19, 2025
Jafaral
added a commit
that referenced
this pull request
Feb 19, 2025
…le/10.2/pr-18121 Revert "bgpd: release manual vpn label on instance deletion (backport #18121)"
Jafaral
added a commit
that referenced
this pull request
Feb 19, 2025
…le/10.0/pr-18121 Revert "bgpd: release manual vpn label on instance deletion (backport #18121)"
Jafaral
added a commit
that referenced
this pull request
Feb 19, 2025
…le/10.1/pr-18121 Revert "bgpd: release manual vpn label on instance deletion (backport #18121)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a BGP instance with a manually assigned VPN label is deleted, the label is not released from the Zebra label registry. As a result, reapplying a configuration with the same manual label leads to VPN prefix export failures.
For example, with the following configuration:
Release zebra label registry on unconfiguration.
Fixes: d162d5f ("bgpd: fix hardset l3vpn label available in mpls pool")