-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: fix false context information for SRv6 route #18023
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Mergifyio backport dev/10.3 stable/10.2 stable/10.1 stable/10.0 |
✅ Backports have been created
|
The seg6local route dumped by 'show ipv6 route' makes think that the USP flavor is supported, whereas it is not the case. This information is a context information, and for End, the context information should be empty. > # show ipv6 route > [..] > I>* fc00:0:4::/128 [115/0] is directly connected, sr0, seg6local End USP, weight 1, 00:49:01 Fix this by suppressing the USP information from the output. Fixes: e496b42 ("bgpd: prefix-sid srv6 l3vpn service tlv") Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
340bf2d
to
658bf02
Compare
cscarpitta
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Feb 13, 2025
Jafaral
added a commit
that referenced
this pull request
Feb 14, 2025
lib: fix false context information for SRv6 route (backport #18023)
Jafaral
added a commit
that referenced
this pull request
Feb 14, 2025
lib: fix false context information for SRv6 route (backport #18023)
This was referenced Feb 14, 2025
donaldsharp
added a commit
that referenced
this pull request
Feb 15, 2025
…p_for_10.0 lib: fix false context information for SRv6 route (backport #18023 for 10.0)
donaldsharp
added a commit
that referenced
this pull request
Feb 15, 2025
…p_for_10.1 lib: fix false context information for SRv6 route (backport #18023 for 10.1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The seg6local route dumped by 'show ipv6 route' makes think that the USP flavor is supported, whereas it is not the case. This information is a context information, and for End, the context information should be empty.
Fix this by suppressing the USP information from the output.
Fixes: e496b42 ("bgpd: prefix-sid srv6 l3vpn service tlv")