zebra, bgp: Support type-5 routes with asymmetric routing #1736

mkanjari · 2018-02-10T00:36:56Z

Asymmetric routing is an ideal choice when all VLANs are cfged on all leafs.
It simplifies the routing configuration and
eliminates potential need for advertising subnet routes.
However, we need to reach the Internet or global destinations
or to do subnet-based routing between PODs or DCs.
This requires EVPN type-5 routes but those routes require L3 VNI configuration.

This task is to support EVPN type-5 routes for prefix-based routing in
conjunction with asymmetric routing within the POD/DC.
It is done by providing an option to use the L3 VNI only for prefix routes,
so that type-2 routes (host routes) will only use the L2 VNI.

Signed-off-by: Mitesh Kanjariya mitesh@cumulusnetworks.com

LabN-CI · 2018-02-10T00:41:08Z

🛑 Basic BGPD CI results: FAILURE

Results table

_	_
Result	FAILURE git merge/1736 `235a907` frr.github Build
Date	02/09/2018
Start	19:40:40
Finish	19:41:06
Run-Time	00:26
Total
Pass
Fail
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2018-02-09-19:40:40.txt
Log	make-2018-02-09-19:40:40.out.bz2

For details, please contact louberger

NetDEF-CI · 2018-02-10T00:54:37Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2534/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Failed

Ubuntu1404 amd64 build: Failed

Make failed for Ubuntu1404 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2534/artifact/CI001BUILD/ErrorLog/log_make.txt)

zebra/zebra_vxlan.o: In function `zebra_vxlan_print_vni':
/home/ci/cibuild.2534/frr-source/zebra/zebra_vxlan.c:4602: undefined reference to `is_vni_l3'
collect2: error: ld returned 1 exit status
make[2]: *** [zebra/zebra] Error 1
make[2]: Leaving directory `/home/ci/cibuild.2534/frr-source'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/ci/cibuild.2534/frr-source'
make: *** [all] Error 2

Ubuntu1404 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2534/artifact/CI001BUILD/config.status/config.status

Ubuntu1604 amd64 build: Failed

Make failed for Ubuntu1604 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2534/artifact/CI014BUILD/ErrorLog/log_make.txt)

zebra/zebra_vxlan.o: In function `zebra_vxlan_print_vni':
/home/ci/cibuild.2534/frr-source/zebra/zebra_vxlan.c:4602: undefined reference to `is_vni_l3'
collect2: error: ld returned 1 exit status
Makefile:3092: recipe for target 'zebra/zebra' failed
make[2]: Leaving directory '/home/ci/cibuild.2534/frr-source'
make[2]: *** [zebra/zebra] Error 1
Makefile:4242: recipe for target 'all-recursive' failed
make[1]: Leaving directory '/home/ci/cibuild.2534/frr-source'
make[1]: *** [all-recursive] Error 1

Ubuntu1604 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2534/artifact/CI014BUILD/config.status/config.status

FreeBSD11 amd64 build: Failed

Make failed for FreeBSD11 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2534/artifact/CI009BUILD/ErrorLog/log_make.txt)

zebra/zebra_vxlan.o: In function `zebra_vxlan_print_vni':
/usr/home/ci/cibuild.2534/frr-source/zebra/zebra_vxlan.c:4602: undefined reference to `is_vni_l3'
collect2: error: ld returned 1 exit status
gmake[2]: *** [Makefile:3092: zebra/zebra] Error 1
gmake[2]: Leaving directory '/usr/home/ci/cibuild.2534/frr-source'
gmake[1]: *** [Makefile:4241: all-recursive] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.2534/frr-source'
gmake: *** [Makefile:1873: all] Error 2

FreeBSD11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2534/artifact/CI009BUILD/config.status/config.status

CentOS6 amd64 build: Failed

Make failed for CentOS6 amd64 build
see make log in attachment https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2534/artifact/CI006BUILD/ErrorLog/log_make.txt
CentOS6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2534/artifact/CI006BUILD/config.status/config.status

Debian8 amd64 build: Failed

Make failed for Debian8 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2534/artifact/CI008BLD/ErrorLog/log_make.txt)

zebra/zebra_vxlan.o: In function `zebra_vxlan_print_vni':
/home/ci/cibuild.2534/frr-source/zebra/zebra_vxlan.c:4602: undefined reference to `is_vni_l3'
collect2: error: ld returned 1 exit status
Makefile:3082: recipe for target 'zebra/zebra' failed
make[2]: Leaving directory '/home/ci/cibuild.2534/frr-source'
make[2]: *** [zebra/zebra] Error 1
Makefile:4232: recipe for target 'all-recursive' failed
make[1]: Leaving directory '/home/ci/cibuild.2534/frr-source'
Makefile:1863: recipe for target 'all' failed

Debian8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2534/artifact/CI008BLD/config.status/config.status

 symbol  			    in file
is_vni_l3                           zebra/zebra_vxlan.o
ld: fatal: symbol referencing errors. No output written to zebra/.libs/zebra
collect2: error: ld returned 1 exit status
Makefile:3091: recipe for target 'zebra/zebra' failed
gmake[2]: *** [zebra/zebra] Error 1
gmake[2]: Leaving directory '/export/home/ci/cibuild.2534/frr-source'
Makefile:4241: recipe for target 'all-recursive' failed
gmake[1]: Leaving directory '/export/home/ci/cibuild.2534/frr-source'

OmniOS amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2534/artifact/CI010BUILD/config.status/config.status

CentOS7 amd64 build: Failed

Make failed for CentOS7 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2534/artifact/CI005BUILD/ErrorLog/log_make.txt)

zebra/zebra_vxlan.o: In function `zebra_vxlan_print_vni':
/home/ci/cibuild.2534/frr-source/zebra/zebra_vxlan.c:4602: undefined reference to `is_vni_l3'
collect2: error: ld returned 1 exit status
make[2]: Leaving directory `/home/ci/cibuild.2534/frr-source'
make[2]: *** [zebra/zebra] Error 1
make[1]: Leaving directory `/home/ci/cibuild.2534/frr-source'
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

CentOS7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2534/artifact/CI005BUILD/config.status/config.status

Debian9 amd64 build: Failed

Make failed for Debian9 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2534/artifact/CI021BUILD/ErrorLog/log_make.txt)

zebra/zebra_vxlan.o: In function `zebra_vxlan_print_vni':
/home/ci/cibuild.2534/frr-source/zebra/zebra_vxlan.c:4602: undefined reference to `is_vni_l3'
collect2: error: ld returned 1 exit status
Makefile:3092: recipe for target 'zebra/zebra' failed
make[2]: Leaving directory '/home/ci/cibuild.2534/frr-source'
make[2]: *** [zebra/zebra] Error 1
Makefile:4242: recipe for target 'all-recursive' failed
make[1]: Leaving directory '/home/ci/cibuild.2534/frr-source'
Makefile:1874: recipe for target 'all' failed

Debian9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2534/artifact/CI021BUILD/config.status/config.status

Ubuntu1204 amd64 build: Failed

Make failed for Ubuntu1204 amd64 build
see make log in attachment https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2534/artifact/CI002BUILD/ErrorLog/log_make.txt
Ubuntu1204 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2534/artifact/CI002BUILD/config.status/config.status

OpenBSD60 amd64 build: Failed

Make failed for OpenBSD60 amd64 build
see make log in attachment https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2534/artifact/CI011BUILD/ErrorLog/log_make.txt
OpenBSD60 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2534/artifact/CI011BUILD/config.status/config.status

FreeBSD10 amd64 build: Failed

Make failed for FreeBSD10 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2534/artifact/CI003BUILD/ErrorLog/log_make.txt)

zebra/zebra_vxlan.o: In function `zebra_vxlan_print_vni':
/usr/home/ci/cibuild.2534/frr-source/zebra/zebra_vxlan.c:4602: undefined reference to `is_vni_l3'
collect2: error: ld returned 1 exit status
gmake[2]: *** [Makefile:3092: zebra/zebra] Error 1
gmake[2]: Leaving directory '/usr/home/ci/cibuild.2534/frr-source'
gmake[1]: *** [Makefile:4241: all-recursive] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.2534/frr-source'
gmake: *** [Makefile:1873: all] Error 2

FreeBSD10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2534/artifact/CI003BUILD/config.status/config.status

NetBSD7 amd64 build: Failed

Make failed for NetBSD7 amd64 build
see make log in attachment https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2534/artifact/CI012BUILD/ErrorLog/log_make.txt
NetBSD7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2534/artifact/CI012BUILD/config.status/config.status

Fedora24 amd64 build: Failed

Make failed for Fedora24 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2534/artifact/CI015BUILD/ErrorLog/log_make.txt)

zebra/zebra_vxlan.o: In function `zebra_vxlan_print_vni':
/home/ci/cibuild.2534/frr-source/zebra/zebra_vxlan.c:4602: undefined reference to `is_vni_l3'
collect2: error: ld returned 1 exit status
Makefile:3091: recipe for target 'zebra/zebra' failed
make[2]: *** [zebra/zebra] Error 1
make[2]: Leaving directory '/home/ci/cibuild.2534/frr-source'
Makefile:4241: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/home/ci/cibuild.2534/frr-source'

Fedora24 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2534/artifact/CI015BUILD/config.status/config.status

NetDEF-CI · 2018-02-10T07:48:58Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2541/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

Github Pull Request 1736, comparing to Git base SHA 5651675

No Changes in Static Analysis warnings compared to base

20 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2541/artifact/shared/static_analysis/index.html

Asymmetric routing is an ideal choice when all VLANs are cfged on all leafs. It simplifies the routing configuration and eliminates potential need for advertising subnet routes. However, we need to reach the Internet or global destinations or to do subnet-based routing between PODs or DCs. This requires EVPN type-5 routes but those routes require L3 VNI configuration. This task is to support EVPN type-5 routes for prefix-based routing in conjunction with asymmetric routing within the POD/DC. It is done by providing an option to use the L3 VNI only for prefix routes, so that type-2 routes (host routes) will only use the L2 VNI. Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>

LabN-CI · 2018-02-10T09:08:38Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/1736 `c48d9f5`
Date	02/10/2018
Start	03:45:13
Finish	04:08:36
Run-Time	23:23
Total	1805
Pass	1805
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2018-02-10-03:45:13.txt
Log	autoscript-2018-02-10-03:45:54.log.bz2

For details, please contact louberger

NetDEF-CI · 2018-02-10T09:36:44Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2542/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

Github Pull Request 1736, comparing to Git base SHA 5651675

No Changes in Static Analysis warnings compared to base

20 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2542/artifact/shared/static_analysis/index.html

LabN-CI · 2018-02-12T10:27:49Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/1736 `efc812a`
Date	02/12/2018
Start	05:05:13
Finish	05:27:47
Run-Time	22:34
Total	1808
Pass	1808
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2018-02-12-05:05:13.txt
Log	autoscript-2018-02-12-05:05:49.log.bz2

For details, please contact louberger

NetDEF-CI · 2018-02-12T10:57:48Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2549/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

Github Pull Request 1736, comparing to Git base SHA 4200166

No Changes in Static Analysis warnings compared to base

20 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2549/artifact/shared/static_analysis/index.html

mkanjari · 2018-02-12T10:59:00Z

@pguibert6WIND : Could you please help in reviewing this PR ?

pguibert6WIND · 2018-02-13T12:36:46Z

Hi @mkanjari ,
I will review it within that week. sorry for delay.

pguibert6WIND · 2018-02-13T17:12:02Z

general review after todays meeting : those feature lack some testing on topotest.

mkanjari · 2018-02-24T00:58:22Z

@pguibert6WIND : Could you please help in merging this when you get a chance. Seems like all checks have passed and the review is approved.

mkanjari force-pushed the type5-with-asymm branch from 235a907 to 7cea11c Compare February 10, 2018 07:00

mkanjari force-pushed the type5-with-asymm branch from 7cea11c to c48d9f5 Compare February 10, 2018 08:42

Merge branch 'master' into type5-with-asymm

efc812a

donaldsharp requested a review from pguibert6WIND February 13, 2018 16:49

pguibert6WIND approved these changes Feb 20, 2018

View reviewed changes

pguibert6WIND merged commit ac3133a into FRRouting:master Feb 27, 2018

mkanjari deleted the type5-with-asymm branch February 27, 2018 09:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

zebra, bgp: Support type-5 routes with asymmetric routing #1736

zebra, bgp: Support type-5 routes with asymmetric routing #1736

mkanjari commented Feb 10, 2018

LabN-CI commented Feb 10, 2018

NetDEF-CI commented Feb 10, 2018

NetDEF-CI commented Feb 10, 2018

LabN-CI commented Feb 10, 2018

NetDEF-CI commented Feb 10, 2018

LabN-CI commented Feb 12, 2018

NetDEF-CI commented Feb 12, 2018

mkanjari commented Feb 12, 2018

pguibert6WIND commented Feb 13, 2018

pguibert6WIND commented Feb 13, 2018

mkanjari commented Feb 24, 2018

zebra, bgp: Support type-5 routes with asymmetric routing #1736

zebra, bgp: Support type-5 routes with asymmetric routing #1736

Conversation

mkanjari commented Feb 10, 2018

LabN-CI commented Feb 10, 2018

🛑 Basic BGPD CI results: FAILURE

NetDEF-CI commented Feb 10, 2018

Continuous Integration Result: FAILED

Get source and apply patch from patchwork: Successful

Building Stage: Failed

Ubuntu1404 amd64 build: Failed

Ubuntu1604 amd64 build: Failed

FreeBSD11 amd64 build: Failed

CentOS6 amd64 build: Failed

Debian8 amd64 build: Failed

NetBSD6 amd64 build: Failed

FreeBSD9 amd64 build: Failed

OmniOS amd64 build: Failed

CentOS7 amd64 build: Failed

Debian9 amd64 build: Failed

Ubuntu1204 amd64 build: Failed

OpenBSD60 amd64 build: Failed

FreeBSD10 amd64 build: Failed

NetBSD7 amd64 build: Failed

Fedora24 amd64 build: Failed

NetDEF-CI commented Feb 10, 2018

Continuous Integration Result: SUCCESSFUL

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

20 Static Analyzer issues remaining.

LabN-CI commented Feb 10, 2018

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Feb 10, 2018

Continuous Integration Result: SUCCESSFUL

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

20 Static Analyzer issues remaining.

LabN-CI commented Feb 12, 2018

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Feb 12, 2018

Continuous Integration Result: SUCCESSFUL

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

20 Static Analyzer issues remaining.

mkanjari commented Feb 12, 2018

pguibert6WIND commented Feb 13, 2018

pguibert6WIND commented Feb 13, 2018

mkanjari commented Feb 24, 2018