Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working/master/pre vpn vrf leak indenting #1735

Conversation

paulzlabn
Copy link
Contributor

bgpd: ran indent.py on some files prior to bgp vpn-vrf leaking changes

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2529/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.


CLANG Static Analyzer Summary

  • Github Pull Request 1735, comparing to Git base SHA 509d742

No Changes in Static Analysis warnings compared to base

21 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2529/artifact/shared/static_analysis/index.html

Copy link
Member

@qlyoung qlyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can please fix the 2 things I noted, otherwise LGTM and I'll merge it

bgpd/bgp_route.c Outdated
* * stats for the thread-walk (i.e. ensure this can't be blamed on
* * on just vty_read()).
* */
* * stats for the thread-walk (i.e. ensure this can't be blamed on
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you manually fix this while we're in here

bgpd/bgpd.h Outdated

/* Statistics field */
_Atomic uint32_t open_in; /* Open message input count */
_Atomic uint32_t open_out; /* Open message output count */
_Atomic uint32_t open_in; /* Open message input count */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please realign these

@LabN-CI
Copy link
Collaborator

LabN-CI commented Feb 9, 2018

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/1735 a4d82a8
Date 02/09/2018
Start 14:18:16
Finish 14:41:12
Run-Time 22:56
Total 1805
Pass 1805
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2018-02-09-14:18:16.txt
Log autoscript-2018-02-09-14:18:52.log.bz2

For details, please contact louberger

Signed-off-by: G. Paul Ziemba <paulz@labn.net>
@LabN-CI
Copy link
Collaborator

LabN-CI commented Feb 9, 2018

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/1735 d316210
Date 02/09/2018
Start 16:15:13
Finish 16:38:36
Run-Time 23:23
Total 1805
Pass 1805
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2018-02-09-16:15:13.txt
Log autoscript-2018-02-09-16:15:55.log.bz2

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2531/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.


CLANG Static Analyzer Summary

  • Github Pull Request 1735, comparing to Git base SHA 509d742

No Changes in Static Analysis warnings compared to base

21 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2531/artifact/shared/static_analysis/index.html

@donaldsharp donaldsharp merged commit 4200166 into FRRouting:master Feb 10, 2018
@louberger louberger deleted the working/master/pre-vpn-vrf-leak-indenting branch May 9, 2018 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants