-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Working/master/pre vpn vrf leak indenting #1735
Working/master/pre vpn vrf leak indenting #1735
Conversation
Signed-off-by: G. Paul Ziemba <paulz@labn.net>
…m/LabNConsulting/frr into working/master/json-bgp-vpn-fixes
Signed-off-by: G. Paul Ziemba <paulz@labn.net>
Signed-off-by: G. Paul Ziemba <paulz@labn.net>
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2529/ This is a comment from an EXPERIMENTAL automated CI system. CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base21 Static Analyzer issues remaining.See details at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can please fix the 2 things I noted, otherwise LGTM and I'll merge it
bgpd/bgp_route.c
Outdated
* * stats for the thread-walk (i.e. ensure this can't be blamed on | ||
* * on just vty_read()). | ||
* */ | ||
* * stats for the thread-walk (i.e. ensure this can't be blamed on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you manually fix this while we're in here
bgpd/bgpd.h
Outdated
|
||
/* Statistics field */ | ||
_Atomic uint32_t open_in; /* Open message input count */ | ||
_Atomic uint32_t open_out; /* Open message output count */ | ||
_Atomic uint32_t open_in; /* Open message input count */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please realign these
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Signed-off-by: G. Paul Ziemba <paulz@labn.net>
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2531/ This is a comment from an EXPERIMENTAL automated CI system. CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base21 Static Analyzer issues remaining.See details at |
bgpd: ran indent.py on some files prior to bgp vpn-vrf leaking changes