Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib, test: fix display ipv4 mapped ipv6 addresses #16452

Merged
merged 2 commits into from
Oct 16, 2024
Merged

lib, test: fix display ipv4 mapped ipv6 addresses #16452

merged 2 commits into from
Oct 16, 2024

Conversation

louis-6wind
Copy link
Contributor

Display ipv4 mapped ipv6 addresses in the format ::ffff:A.B.C.D.

@frrbot frrbot bot added bugfix libfrr tests Topotests, make check, etc labels Jul 24, 2024
ton31337
ton31337 approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but some tests still need to be adopted for a new output value.

riw777
riw777 approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777
Copy link
Member

riw777 commented Jul 30, 2024

should this be put in together with #16439 ?? would it pass ci if these were one commit?

@mwinter-osr
Copy link
Member

CI:rerun

@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@riw777
Copy link
Member

riw777 commented Sep 17, 2024

@Mergifyio rebase

@mergify Mergify
Copy link

mergify bot commented Sep 17, 2024

rebase

☑️ Nothing to do

  • -conflict [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • queue-position = -1 [📌 rebase requirement]
  • any of:
    • #commits > 1 [📌 rebase requirement]
    • #commits-behind > 0 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]

@riw777
Copy link
Member

riw777 commented Sep 17, 2024

the conflicts need to be fixed on this and it needs to be rebased so we can try to get it through ci ...

@louis-6wind
lib, test: fix display ipv4 mapped ipv6 addresses
84ab021 
Display ipv4 mapped ipv6 addresses in the format ::ffff:A.B.C.D.

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind
tests: update fuzz after ipv4 mapped ipv6 print change
3c430cd 
Update IS-IS fuzz test to match corrected output after change in the
display of IPv4 mapped IPv6 address.

The update was performed using wuschl [1] like this:

$ wuschl rebuild tests/isisd/test_fuzz_isis_tlv
$ gzip -9 tests/isisd/test_fuzz_isis_tlv_tests.h

[1] https://pypi.org/project/wuschl/

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind louis-6wind force-pushed the fix-ipv4-mapped-ipv6-display branch from 44ec337 to 3c430cd Compare October 16, 2024 11:46
@riw777 riw777 merged commit 75e34c0 into FRRouting:master Oct 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riw777 riw777 riw777 approved these changes

@ton31337 ton31337 ton31337 approved these changes

Assignees
No one assigned
Labels
bugfix libfrr master size/L tests Topotests, make check, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@louis-6wind @riw777 @mwinter-osr @ton31337