bgpd: fix failing to compile on 32 bit systems

[donaldsharp]

-Werror=sign-compare is failing with signed/unsigned usage
in the conditional expression.

Fixes: #1593
Signed-off-by: Donald Sharp sharpd@cumulusnetworks.com

[LabN-CI]

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/1594 8356e9b
Date	01/04/2018
Start	05:50:09
Finish	06:13:03
Run-Time	22:54
Total	1808
Pass	1808
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2018-01-04-05:50:09.txt
Log	autoscript-2018-01-04-05:50:51.log.bz2

For details, please contact louberger

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2250/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

---

CLANG Static Analyzer Summary

• Github Pull Request 1594, comparing to Git base SHA 3cace9d

No Changes in Static Analysis warnings compared to base

21 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2250/artifact/shared/static_analysis/index.html

[NetDEF-CI]

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2251/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Successful

Basic Tests: Failed

Fedora 24 rpm pkg check: Successful
Addresssanitizer topotest: Successful
Debian 8 deb pkg check: Successful
IPv4 protocols on Ubuntu 14.04: Successful
Debian 9 deb pkg check: Successful
IPv4 ldp protocol on Ubuntu 16.04: Successful
Ubuntu 14.04 deb pkg check: Successful
CentOS 7 rpm pkg check: Successful
Ubuntu 12.04 deb pkg check: Successful
Static analyzer (clang): Successful
CentOS 6 rpm pkg check: Successful
IPv6 protocols on Ubuntu 14.04: Successful
Ubuntu 16.04 deb pkg check: Successful

Topology tests on Ubuntu 16.04 amd64: Failed

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-2251/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:

2018-01-04 05:07:52,645 ERROR: ******************************************************************************
2018-01-04 05:07:52,646 ERROR: Test Target Summary                                                  Pass Fail
2018-01-04 05:07:52,647 ERROR: ******************************************************************************
2018-01-04 05:07:52,647 ERROR: 3    r3     Adjacencies up +10.09 secs                               0    1
2018-01-04 05:07:52,647 ERROR: ******************************************************************************
2018-01-04 05:07:52,647 ERROR: Total 49                                                             39   1
2018-01-04 05:07:52,647 ERROR: ******************************************************************************
2018-01-04 05:07:52,647 ERROR: See /tmp/topotests/bgp_direct_to_bgp_vpn.test_bgp_direct_to_bgp_vpn/output.log for details of errors
2018-01-04 05:07:52,652 ERROR: assert failed at "bgp_direct_to_bgp_vpn.test_bgp_direct_to_bgp_vpn/test_run_lu_tests": 1 tests failed
assert '1 tests failed' == 'See summary output above'
  - 1 tests failed
  + See summary output above

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2251/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2251/artifact/TOPOU1604/MemoryLeaks/

CLANG Static Analyzer Summary

• Github Pull Request 1594, comparing to Git base SHA 3cace9d

No Changes in Static Analysis warnings compared to base

21 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2251/artifact/shared/static_analysis/index.html

[pguibert6WIND]

Hi,
I may have merged this by mistake, I was thinking the fix was ok, because I had the same.
It looks like it is not enough?

[donaldsharp]

@pguibert6WIND not sure yet, I'm rerunning the failed topotests now. I've personally seen a lot of failures the last few days of the topotests. I am not sure how this would cause a new failure though with what I have done. I am looking into it now.

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2251/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

---

CLANG Static Analyzer Summary

• Github Pull Request 1594, comparing to Git base SHA 3cace9d

No Changes in Static Analysis warnings compared to base

21 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2251/artifact/shared/static_analysis/index.html