bgpd: Speedup vtysh handling of 'show bgp afi safi json' display

[donaldsharp]

When bgp has a metric butt-load of routes w/ ecmp, this command
can take an inordinate amount of time to run and complete via
vtysh.

Converting the bgp route output in this case back to not
using the json pretty-print drops ~2 minutes of runtime
off.

It is assumed that if users would like pretty output they
can run it through an appropriate tool via a pipe command.

Signed-off-by: Donald Sharp sharpd@cumulusnetworks.com

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2175/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

---

Warnings Generated during build:

Debian8 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2175/artifact/CI008BLD/ErrorLog/log_lintian.txt)

W: frr-dbg: debug-file-with-no-debug-symbols usr/lib/debug/usr/lib/libfrrfpm_pb.so.0.0.0
N: 5 tags overridden (5 warnings)

Ubuntu1404 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu1404 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2175/artifact/CI001BUILD/ErrorLog/log_lintian.txt)

W: frr-dbg: debug-file-with-no-debug-symbols usr/lib/debug/usr/lib/libfrrfpm_pb.so.0.0.0
N: 5 tags overridden (5 warnings)

---

CLANG Static Analyzer Summary

• Github Pull Request 1553, comparing to Git base SHA cb9cef7
• Base image data for Git cb9cef7 does not exist - compare skipped

23 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2175/artifact/shared/static_analysis/index.html

[LabN-CI]

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/1553 23b2a7e
Date	12/14/2017
Start	10:38:21
Finish	11:01:24
Run-Time	23:03
Total	1808
Pass	1808
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2017-12-14-10:38:21.txt
Log	autoscript-2017-12-14-10:38:59.log.bz2

For details, please contact louberger