Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zserv.h modifications #1527

Merged
merged 3 commits into from
Dec 14, 2017
Merged

Zserv.h modifications #1527

merged 3 commits into from
Dec 14, 2017

Conversation

donaldsharp
Copy link
Member

zserv.[ch] have become a bit of a dumping ground for functions and their declarations. Modify these two to put code in places where they belong better.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Dec 8, 2017

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/1527 30c30cd
Date 12/07/2017
Start 18:45:09
Finish 19:09:04
Run-Time 23:55
Total 1808
Pass 1808
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2017-12-07-18:45:09.txt
Log autoscript-2017-12-07-18:45:48.log.bz2

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2137/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Ubuntu1404 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu1404 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2137/artifact/CI001BUILD/ErrorLog/log_lintian.txt)

W: frr-dbg: debug-file-with-no-debug-symbols usr/lib/debug/usr/lib/libfrrfpm_pb.so.0.0.0
N: 5 tags overridden (5 warnings)

Debian8 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2137/artifact/CI008BLD/ErrorLog/log_lintian.txt)

W: frr-dbg: debug-file-with-no-debug-symbols usr/lib/debug/usr/lib/libfrrfpm_pb.so.0.0.0
N: 5 tags overridden (5 warnings)

CLANG Static Analyzer Summary

  • Github Pull Request 1527, comparing to Git base SHA a457559

No Changes in Static Analysis warnings compared to base

23 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2137/artifact/shared/static_analysis/index.html

@donaldsharp
Copy link
Member Author

There are whitespace issues that need to be cleaned up

@donaldsharp
zebra: Move zebrad initialization outside of cli init
5f145fb 
The zebrad initialization does not need to be part of cli
initialization and should be done separately.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@donaldsharp
zebra: Try to move non zapi cli commands from zserv.c
c0d136a 
zserv.c has become a bit of a dumping ground for zebra cli.
I'd like to focus the zserv.c code into it's core functionality
which is handling the zapi interface.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@donaldsharp
zebra: Make zserv.h the true api for zapi northbound
05f7f5d 
zserv.c had a grab bag of function declarations that
did not belong in it.  Move those to where they better
belong.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@donaldsharp
Copy link
Member Author

@rzalamena I have made the whitespace fixes here.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Dec 13, 2017

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/1527 05f7f5d
Date 12/13/2017
Start 08:03:13
Finish 08:26:04
Run-Time 22:51
Total 1805
Pass 1805
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2017-12-13-08:03:13.txt
Log autoscript-2017-12-13-08:03:49.log.bz2

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2158/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Ubuntu1404 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu1404 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2158/artifact/CI001BUILD/ErrorLog/log_lintian.txt)

W: frr-dbg: debug-file-with-no-debug-symbols usr/lib/debug/usr/lib/libfrrfpm_pb.so.0.0.0
N: 5 tags overridden (5 warnings)

Debian8 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2158/artifact/CI008BLD/ErrorLog/log_lintian.txt)

W: frr-dbg: debug-file-with-no-debug-symbols usr/lib/debug/usr/lib/libfrrfpm_pb.so.0.0.0
N: 5 tags overridden (5 warnings)

CLANG Static Analyzer Summary

  • Github Pull Request 1527, comparing to Git base SHA db33b83

No Changes in Static Analysis warnings compared to base

23 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2158/artifact/shared/static_analysis/index.html

@rwestphal rwestphal merged commit cb9cef7 into FRRouting:master Dec 14, 2017
@donaldsharp donaldsharp deleted the zserv_thread branch March 24, 2018 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@donaldsharp @LabN-CI @NetDEF-CI @rwestphal