Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSPFV3:When the SAID of the Authentication Trailer is different, a neighbor is formed. #16100

Closed
2 tasks done
lijinxianglogo opened this issue May 29, 2024 · 5 comments
Closed
2 tasks done
Labels
triage Needs further investigation

Comments

@lijinxianglogo
Copy link

Description

node A:
key-id 30
image
nodeB:
key-id 10
image

The neighbor status is full
image

Version

FRRouting 9.1 (localhost.localdomain) on Linux(3.10.0-1127.el7.x86_64).
Copyright 1996-2005 Kunihiro Ishiguro, et al.
configured with:
    '--build=x86_64-redhat-linux-gnu' '--host=x86_64-redhat-linux-gnu' '--program-prefix=' '--disable-dependency-tracking' '--prefix=/usr' '--exec-prefix=/usr' '--bindir=/usr/bin' '--sysconfdir=/etc' '--datadir=/usr/share' '--includedir=/usr/include' '--libdir=/usr/lib64' '--libexecdir=/usr/libexec' '--localstatedir=/var' '--sharedstatedir=/var/lib' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--sbindir=/usr/lib/frr' '--sysconfdir=/etc/frr' '--localstatedir=/var/run/frr' '--disable-static' '--disable-werror' '--enable-irdp' '--enable-multipath=256' '--enable-vtysh' '--enable-ospfclient' '--enable-ospfapi' '--enable-rtadv' '--enable-ldpd' '--enable-pimd' '--enable-pim6d' '--enable-pbrd' '--enable-nhrpd' '--enable-eigrpd' '--enable-babeld' '--enable-vrrpd' '--enable-user=frr' '--enable-group=frr' '--enable-vty-group=frrvty' '--enable-fpm' '--enable-watchfrr' '--disable-bgp-vnc' '--enable-isisd' '--enable-rpki' '--enable-bfdd' '--enable-pathd' '--enable-snmp' 'build_alias=x86_64-redhat-linux-gnu' 'host_alias=x86_64-redhat-linux-gnu' 'PKG_CONFIG_PATH=:/usr/lib64/pkgconfig:/usr/share/pkgconfig'

How to reproduce

Follow the description to reproduce

Expected behavior

unable to form neighbors

Actual behavior

Neighbors formed normally

Additional context

image
https://www.rfc-editor.org/rfc/rfc6506

Checklist

  • I have searched the open issues for this bug.
  • I have not included sensitive information in this report.
@lijinxianglogo lijinxianglogo added the triage Needs further investigation label May 29, 2024
@lijinxianglogo
Copy link
Author

@ton31337 can you help me?

@aceelindem
Copy link
Collaborator

This is a valid problem and I have a fix. Refer to RFC 7166, section 4.6:

The receiving interface's OSPFv3 SA is located using the SA ID in the
received AT. If the SA is not found, or if the SA is not valid for
reception (i.e., current time < KeyStartAccept or
current time >= KeyStopAccept), the OSPFv3 packet is dropped.

aceelindem added a commit to LabNConsulting/frr that referenced this issue Jun 4, 2024
    Also, add topotest variation to verify checking.

    This corrects FRRouting#16100.

Signed-off-by: Acee Lindem <acee@lindem.com>
@lijinxianglogo
Copy link
Author

This is a valid problem and I have a fix. Refer to RFC 7166, section 4.6:

The receiving interface's OSPFv3 SA is located using the SA ID in the received AT. If the SA is not found, or if the SA is not valid for reception (i.e., current time < KeyStartAccept or current time >= KeyStopAccept), the OSPFv3 packet is dropped.

Thank you very much for your help my friend

@aceelindem
Copy link
Collaborator

aceelindem commented Jul 16, 2024

This issue can be closed - it is fixed.

@riw777 riw777 closed this as completed Jul 16, 2024
@lijinxianglogo
Copy link
Author

commit: 3f359d7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs further investigation
Projects
None yet
Development

No branches or pull requests

3 participants