Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snmpbulkwalk stopped working #15680

Closed
MattiKoskinenUnikie opened this issue Apr 4, 2024 · 2 comments · Fixed by #15819
Closed

snmpbulkwalk stopped working #15680

MattiKoskinenUnikie opened this issue Apr 4, 2024 · 2 comments · Fixed by #15819

Comments

@MattiKoskinenUnikie
Copy link

after updating version of FRRouting from 8.4 to 9.1we started getting errors when executing snmpbulkwalk … .1.3.6.1.2.1.14

STDERR:
Error: OID not increasing: OSPF-MIB::ospfIfIpAddress.172.0.100.1.0

= OSPF-MIB::ospfIfIpAddress.172.0.100.1.0Error: OID not increasing: OSPF-MIB::ospfIfIpAddress.172.0.100.1.0
= OSPF-MIB::ospfIfIpAddress.172.0.100.1.0Error: OID not increasing: OSPF-MIB::ospfIfIpAddress.172.0.100.1.0
= OSPF-MIB::ospfIfIpAddress.172.0.100.1.0Error: OID not increasing: OSPF-MIB::ospfIfIpAddress.172.0.100.1.0
= OSPF-MIB::ospfIfIpAddress.172.0.100.1.0Error: OID not increasing: OSPF-MIB::ospfIfIpAddress.172.0.100.1.0
= OSPF-MIB::ospfIfIpAddress.172.0.100.1.0Error: OID not increasing: OSPF-MIB::ospfIfIpAddress.172.0.100.1.0
= OSPF-MIB::ospfIfIpAddress.172.0.100.1.0Error: OID not increasing: OSPF-MIB::ospfIfIpAddress.172.0.100.1.0
= OSPF-MIB::ospfIfIpAddress.172.0.100.1.0Error: OID not increasing: OSPF-MIB::ospfIfIpAddress.172.0.100.1.0
= OSPF-MIB::ospfIfIpAddress.172.0.100.1.0Error: OID not increasing: OSPF-MIB::ospfIfIpAddress.172.0.100.1.0

I suspect that this is due to commit 438ef98

The offset is advanced by one even though IN_ADDR_SIZE number of items are read.
@louis-6wind
Copy link
Contributor

@MattiKoskinenUnikie Have you tried to revert commit 438ef98 to see if it fixes the issue?

@MattiKoskinenUnikie
Copy link
Author

I tried, and it fixed.

@louis-6wind louis-6wind mentioned this issue Apr 23, 2024
Merged
louis-6wind added a commit to louis-6wind/frr that referenced this issue Apr 23, 2024
@louis-6wind
Revert "ospfd: fix some dicey pointer arith in snmp module"
c7895ba 
This reverts commit 438ef98.

The previous code was correct even if the coverity scanner was
complaining.

Fixes: FRRouting#15680
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
louis-6wind added a commit to louis-6wind/frr that referenced this issue Apr 23, 2024
@louis-6wind
Revert "bgpd: fix pointer arithmetic in bgp snmp module"
c1124a4 
This reverts commit d9bd9eb.

The previous code was correct even if the coverity scanner was
complaining.

Fixes: FRRouting#15680
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
@louis-6wind louis-6wind mentioned this issue Apr 23, 2024
Merged
mergify bot pushed a commit that referenced this issue Apr 24, 2024
@louis-6wind @mergify
Revert "ospfd: fix some dicey pointer arith in snmp module"
698a180 
This reverts commit 438ef98.

The previous code was correct even if the coverity scanner was
complaining.

Fixes: #15680
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
(cherry picked from commit c7895ba)
mergify bot pushed a commit that referenced this issue Apr 24, 2024
@louis-6wind @mergify
Revert "bgpd: fix pointer arithmetic in bgp snmp module"
9e5accc 
This reverts commit d9bd9eb.

The previous code was correct even if the coverity scanner was
complaining.

Fixes: #15680
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
(cherry picked from commit c1124a4)
@mergify mergify bot mentioned this issue Apr 24, 2024
Merged
mergify bot pushed a commit that referenced this issue Apr 24, 2024
@louis-6wind @mergify
Revert "ospfd: fix some dicey pointer arith in snmp module"
11a9bc2 
This reverts commit 438ef98.

The previous code was correct even if the coverity scanner was
complaining.

Fixes: #15680
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
(cherry picked from commit c7895ba)
mergify bot pushed a commit that referenced this issue Apr 24, 2024
@louis-6wind @mergify
Revert "bgpd: fix pointer arithmetic in bgp snmp module"
c5eff5e 
This reverts commit d9bd9eb.

The previous code was correct even if the coverity scanner was
complaining.

Fixes: #15680
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
(cherry picked from commit c1124a4)
@mergify mergify bot mentioned this issue Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bgpd, ospfd: fix non increasing SNMP OID louis-6wind/frr
2 participants
@louis-6wind @MattiKoskinenUnikie