Skip to content

Commit

Permalink
pimd: fix null memory access on IGMP source limit
Browse files Browse the repository at this point in the history
When the IGMP group source limit is reached the function
`igmp_get_source_by_addr` won't return a `struct gm_source` so we must
test for that condition before attempting to access its fields.

Fixes coverity scan issue 1637406.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
  • Loading branch information
rzalamena committed Feb 28, 2025
1 parent d49561e commit cacdff7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pimd/pim_igmpv3.c
Original file line number Diff line number Diff line change
Expand Up @@ -843,7 +843,7 @@ static void toex_incl(struct gm_group *group, int num_sources,

/* Lookup reported source (B) */
source = igmp_get_source_by_addr(group, *src_addr, &new);
if (!new) {
if (!new && source != NULL) {
/* If found, clear deletion flag: (A*B) */
IGMP_SOURCE_DONT_DELETE(source->source_flags);
/* and set SEND flag (A*B) */
Expand Down

0 comments on commit cacdff7

Please sign in to comment.