Skip to content

Commit

Permalink
bgpd: Fix up memory leak in processing eoiu marker
Browse files Browse the repository at this point in the history
Memory is being leaked when processing the eoiu marker.
BGP is creating a dummy dest to contain the data but
it was never freed.  As well as the eoiu info was
not being freed either.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
(cherry picked from commit c6b7a99)
  • Loading branch information
donaldsharp authored and mergify[bot] committed Feb 5, 2025
1 parent b2f9962 commit 9b99397
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions bgpd/bgp_route.c
Original file line number Diff line number Diff line change
Expand Up @@ -4120,6 +4120,9 @@ static void process_eoiu_marker(struct bgp_dest *dest)
subqueue2str(META_QUEUE_EOIU_MARKER));

bgp_process_main_one(info->bgp, NULL, 0, 0);

XFREE(MTYPE_BGP_EOIU_MARKER_INFO, info);
XFREE(MTYPE_BGP_NODE, dest);
}

/*
Expand Down Expand Up @@ -4310,6 +4313,7 @@ static void eoiu_marker_queue_free(struct meta_queue *mq, struct bgp_dest_queue
XFREE(MTYPE_BGP_EOIU_MARKER_INFO, dest->info);
STAILQ_REMOVE_HEAD(l, pq);
STAILQ_NEXT(dest, pq) = NULL; /* complete unlink */
XFREE(MTYPE_BGP_NODE, dest);
mq->size--;
}
}
Expand Down

0 comments on commit 9b99397

Please sign in to comment.