update

Signed-off-by: Joe McCain III <jo3mccain@icloud.com>

core/src/actors/engine.rs

@@ -72,7 +72,7 @@ where
         core::mem::replace(&mut self.scope, next);
     }
 
-    pub fn process<I>(&mut self) -> Result<(), Error>
+    pub fn process(&mut self) -> Result<(), Error>
     where
         A: crate::Symbolic,
         Q: Clone + Eq + std::hash::Hash,
@@ -83,8 +83,8 @@ where
             None => return Err(Error::runtime_error("Engine::process")),
         };
 
-        if let Some(rule) = self.program.get(self.scope.state(), &symbol) {
-            self.handle(rule.direction, rule.state.clone(), rule.symbol.clone());
+        if let Some(rule) = self.program.get(self.scope.state(), symbol) {
+            self.handle(rule.direction, rule.state.clone(), rule.symbol);
         }
 
         Ok(())

core/src/actors/exec.rs

@@ -104,7 +104,7 @@ where
             // process the instruction
             self.actor.process(tail.clone());
             // return the head
-            return Some(tail.into_head());
+            Some(tail.into_head())
         } else {
             #[cfg(feature = "tracing")]
             tracing::error!("No symbol found at {}", self.actor.position());

core/src/rules/mod.rs

@@ -124,7 +124,7 @@ impl<Q, S> Scope<Q, S> for Rule<Q, S> {
     }
 
     fn symbol(&self) -> &S {
-        &self.symbol()
+        self.symbol()
     }
 }
 
@@ -138,7 +138,7 @@ impl<Q, S> Directive<Q, S> for Rule<Q, S> {
     }
 
     fn value(&self) -> &S {
-        &self.write_symbol()
+        self.write_symbol()
     }
 }
 
@@ -162,7 +162,7 @@ impl<Q, S> Directive<Q, S> for crate::Tail<Q, S> {
     }
 
     fn value(&self) -> &S {
-        &self.symbol()
+        self.symbol()
     }
 }
 

core/src/rules/rule.rs

@@ -157,7 +157,7 @@ mod impls {
         S: PartialEq,
     {
         fn eq(&self, other: &(Head<Q, S>, Tail<Q, S>)) -> bool {
-            &self.head == &other.0 && &self.tail == &other.1
+            self.head == other.0 && self.tail == other.1
         }
     }
 

core/src/state/halt/mod.rs

@@ -35,7 +35,7 @@ pub trait HaltableExt<Q>: Haltable<Q> {
         F: FnOnce(Q) -> U,
         Self: Sized,
     {
-        self.get().map(|state| f(state))
+        self.get().map(f)
     }
 }
 

core/src/state/impls/impl_ops.rs

@@ -48,7 +48,10 @@ where
     }
 }
 
-impl<Q> num::traits::Num for State<Q> where Q: num::traits::Num {
+impl<Q> num::traits::Num for State<Q>
+where
+    Q: num::traits::Num,
+{
     type FromStrRadixErr = Q::FromStrRadixErr;
 
     fn from_str_radix(str: &str, radix: u32) -> Result<Self, Self::FromStrRadixErr> {

core/src/state/mod.rs

@@ -48,7 +48,9 @@ pub trait RawState {
 pub trait Apply<Q, R> {
     type Output;
 
-    fn apply<F>(self, f: F) -> Self::Output where F: FnOnce(Q) -> R;
+    fn apply<F>(self, f: F) -> Self::Output
+    where
+        F: FnOnce(Q) -> R;
 }
 
 /*
@@ -89,4 +91,3 @@ impl_raw_state! {
     Halt(0),
     State(0),
 }
-

core/src/state/state.rs

@@ -25,7 +25,7 @@ impl<Q> State<Q> {
     }
     /// Casts the state to a new type, returning a new instance of [State].
     ///
-    /// ### Saftey
+    /// # Saftey
     ///
     /// *
     pub unsafe fn cast<R>(self) -> State<R> {

core/src/tape/mod.rs

@@ -100,7 +100,7 @@ where
     }
 
     fn get_mut(&mut self, key: &Self::Key) -> Option<&mut Self::Value> {
-        HashMap::get_mut(self, &key)
+        HashMap::get_mut(self, key)
     }
 
     fn insert(&mut self, key: Self::Key, value: Self::Value) {

core/src/tape/tape.rs

@@ -29,6 +29,12 @@ pub struct StdTape<S = char> {
     ticks: Cell<usize>,
 }
 
+impl<S> Default for StdTape<S> {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl<S> StdTape<S> {
     pub fn new() -> Self {
         StdTape {

core/src/types/head.rs

@@ -293,7 +293,7 @@ where
     S: PartialEq,
 {
     fn eq(&self, head: &Head<Q, S>) -> bool {
-        &head.state == &self.0 && &head.symbol == &self.1
+        head.state == self.0 && head.symbol == self.1
     }
 }
 

core/src/types/tail.rs

@@ -67,7 +67,7 @@ impl<Q, S> Tail<Q, S> {
     }
     /// Returns an instance of the [head](Head) where each element within
     /// the created instance is an immutable reference
-    pub fn to_head_ref<'a>(&'a self) -> Head<&'a Q, &'a S> {
+    pub fn to_head_ref(&self) -> Head<&Q, &S> {
         super::Head::new(self.state.to_ref(), &self.symbol)
     }
 

core/tests/actor.rs

@@ -25,7 +25,7 @@ fn busy_beaver() {
     let initial_state = State(0_isize);
     let input = [0_usize; 10];
 
-    let program = Program::from_iter(RULES.clone());
+    let program = Program::from_iter(*RULES);
 
     let actor = Actor::from_state(initial_state).with_alpha(input);
     let mut rt = actor.execute(program);

core/tests/state.rs

@@ -91,4 +91,4 @@ fn numstate() {
     assert_eq!(one, 1);
     // verify the state has an inner value of 0
     assert_eq!(zero, 0.0);
-}
+}