Add new config options, improve performance, and refactor #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `OOCEukrasia` and `OOCRhizomata` options to `SGE_Default` - Replaced `foreach` loops with `for` loops in `SGE_Default` - Modified logic to check new settings before using abilities - Refactored `ActionTargetInfo` methods to use explicit loops - Updated `FindTargetAreaHostile` to use explicit loops - Renamed `BeneficialAreaStrategy` to `BeneficialAreaStrategy2` - Added VFX path checks and improved VFX casting logic in `DataCenter` - Added UI text element in `RotationConfigWindow` for `VfxDataQueue` - Simplified `Description` property and refactored constructor in `DragFloatSearch` - Adjusted `DragFloatSearch` to handle percentage values in ImGui slider - Reduced VFX expiration time check from 10s to 6s in `MajorUpdater` - Removed unused config options and updated UI in `Configs` - Refactored `RotationConfigFloat` for robust command parsing and value setting - Updated `Configs` to use `BeneficialAreaStrategy2` and adjusted UI - Removed redundant and commented-out code for clarity and maintainability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OOCEukrasiaandOOCRhizomataoptions toSGE_Defaultforeachloops withforloops inSGE_DefaultActionTargetInfomethods to use explicit loopsFindTargetAreaHostileto use explicit loopsBeneficialAreaStrategytoBeneficialAreaStrategy2DataCenterRotationConfigWindowforVfxDataQueueDescriptionproperty and refactored constructor inDragFloatSearchDragFloatSearchto handle percentage values in ImGui sliderMajorUpdaterConfigsRotationConfigFloatfor robust command parsing and value settingConfigsto useBeneficialAreaStrategy2and adjusted UI