Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ds integrals on prism/pyramids generate kernels for each facet type #739

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

mscroggs
Copy link
Member

@mscroggs mscroggs commented Dec 20, 2024

Makes FFCx generate multiple kernels for forms using ds on cells that have facets of multiple types (eg for prisms, it makes kernels for triangles and quadrilaterals)

Key changes:

  • Changed CommonExpressionIR.integrand from dict[QuadratureRule, dict] to dict[tuple[basix.CellType, QuadratureRule], dict] so that the facet type can be included
  • Updated some other parts of CommonExpressionIR to be dicts with basix.CellType keys
  • Added domain input to code generator for integral so that code to integrate on multiple facets can be generated

Resolves #735. Builds on #736 so that should be merged first.

@mscroggs mscroggs marked this pull request as draft December 20, 2024 11:43
@coveralls
Copy link

coveralls commented Dec 20, 2024

Coverage Status

coverage: 82.272% (+0.04%) from 82.231%
when pulling 9881fb7 on mscroggs/prism-ds
into dc60815 on main.

@mscroggs mscroggs marked this pull request as ready for review December 20, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix ffcx to create ds integrals for cells with multiple facet types (pyramid, prism etc.)
3 participants