Mark all nanobind enums as nb::is_arithmetic() for compatibility with nanobind 2.x
#825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garth-wells
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since wjakob/nanobind@d25bde8, conversion of a
nanobindenum value to int is only allowed for enums marked withnb::is_arithmetic(), see for instancewjakob/nanobind@d25bde8#diff-76fe099ab4bd5fcc25f3445a3de0b298c522bfbe4c877d60c64408b2e5cb2346L23
Conversion to integer is required by
basix/python/basix/utils.py
Line 49 in 8818981
The changes in this PR are backward compatible, and thus it can be merged now without waiting for
nanobind2.0. Still, upon release ofnanobindthis PR will need to be backported tobasix0.8.1.Tested against
nanobindmain branch in https://github.com/FEniCS/basix/actions/runs/9016093941, while tested againstnanobind1.9.x in https://github.com/FEniCS/basix/actions/runs/9016171285