Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add permute_subentity_closure function #806

Merged
merged 17 commits into from
May 10, 2024
Merged

Add permute_subentity_closure function #806

merged 17 commits into from
May 10, 2024

Conversation

mscroggs
Copy link
Member

No description provided.

@mscroggs mscroggs added this to the v0.9.0 milestone Apr 19, 2024
@mscroggs mscroggs requested a review from jpdean April 19, 2024 16:54
@mscroggs mscroggs marked this pull request as draft April 22, 2024 09:05
@mscroggs mscroggs marked this pull request as ready for review April 22, 2024 09:19
@mscroggs mscroggs changed the title Add permute_closure_dofs function Add permute_subentity_closure function Apr 22, 2024
jpdean
jpdean reviewed May 5, 2024
View reviewed changes
Copy link
Member

@jpdean jpdean left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking at this, Matt! I have one comment about the interface

cpp/basix/finite-element.h Show resolved Hide resolved
@mscroggs mscroggs added this pull request to the merge queue May 10, 2024
Merged via the queue into main with commit 47c4c55 May 10, 2024
27 checks passed
@mscroggs mscroggs deleted the mscroggs/permute_closure_dofs branch May 10, 2024 15:12
@mscroggs mscroggs mentioned this pull request Jun 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpdean jpdean jpdean left review comments

@garth-wells garth-wells garth-wells left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mscroggs @garth-wells @jpdean