Update nb::ndarray constructor in preparation of next nanobind release
#799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… have a default value. Assign the former default value everywhere in nb wrappers
|
To clarify: in contrast to the nanobind change addressed in the first commit of FEniCS/dolfinx#3105, the nanobind change addressed here is backward compatible: in principle, the PR could be marked as ready to review (and not draft), but I won't do that because the change introduced here isn't necessary for the current nanobind release. |
cc89ae0 to
58ffdc6
Compare
|
@francesco-ballarin I think we should merge this - it will keep the Basix working when nanobind 2.0 is released. |
garth-wells
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to wjakob/nanobind@937a1df which dropped a default value
Not supposed to be merged until the next nanobind release. Coupled with FEniCS/dolfinx#3105