Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dtype when creating elements #796

Merged
merged 29 commits into from
Apr 25, 2024
Merged

dtype when creating elements #796

merged 29 commits into from
Apr 25, 2024

Conversation

mscroggs
Copy link
Member

@mscroggs mscroggs commented Mar 21, 2024

  • Default dtype updated to match DOLFINx (if installed)
  • dtype input added to custom element

Will allow us to do FEniCS/dolfinx#3136

@mscroggs mscroggs requested a review from garth-wells March 21, 2024 17:12
@mscroggs mscroggs marked this pull request as draft March 21, 2024 18:21
@jhale
Copy link
Member

jhale commented Apr 15, 2024

What's the status of this?

@garth-wells
Copy link
Member

I'm not wild about bringing DOLFINx into this. I'd favour defaulting to float64 or being completely explicit on the type.

@jorgensd
Copy link
Member

I'm not wild about bringing DOLFINx into this. I'd favour defaulting to float64 or being completely explicit on the type.

I agree with Garth

@mscroggs
Copy link
Member Author

What's the status of this?

Needs a bit of work before it's ready. Should have time to do this work in the next couple of weeks

@mscroggs mscroggs marked this pull request as ready for review April 16, 2024 09:19
@mscroggs mscroggs marked this pull request as draft April 16, 2024 09:19
@mscroggs mscroggs marked this pull request as ready for review April 16, 2024 09:38
@mscroggs
Copy link
Member Author

What's the status of this?

Needs a bit of work before it's ready. Should have time to do this work in the next couple of weeks

It was less work to fix that I thought it might be. Ready for review now

@jhale jhale added this to the v0.9.0 milestone Apr 16, 2024
python/basix/finite_element.py Outdated Show resolved Hide resolved
python/basix/finite_element.py Outdated Show resolved Hide resolved
python/basix/finite_element.py Outdated Show resolved Hide resolved
@mscroggs mscroggs added this pull request to the merge queue Apr 25, 2024
Merged via the queue into main with commit 2fd27dd Apr 25, 2024
23 checks passed
@mscroggs mscroggs deleted the mscroggs/default_scalar_type branch April 25, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants