feat(teamLogo): ✨ Add the logos on the scoreboard #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected on some bugs on the new features into the Front-End and the Back-End Javascript
Co-authored-by:: The_TecnoKing <75082274+TheTecnoKing@users.noreply.github.com>
- Finished the frontend bits for team logos and added a new default one, courtesy of Flaticon. It's only visible in the main scoreboard right now, but it'll probably be shown in all other scoreboards in the near future as well. - Updated all license key links, now redirecting to our own platform instead of OpenCollective. - Minor bug fixes.
Made the update of the teams logo work on the main scoreboard `app/scoreboard.html`. Prefeard for other scoreboard if used the same query selector `.teamLogo#home>img` @TheTecnoKing
Refactored to improve maintainability score and trying finxing 7 codeclimate issues
Refactored to improve maintainability score and trying finxing one last codeclimate issues
- Team logos are now available on all scoreboards. - Animations have also been added, although they require some touchups. - Added outlines to logo previews in the Control Center. This should make image resizing and positioning easier to understand. - Changed the way logos take up space. They'll now keep their original aspect ratio, while trying to fill most of the area they have. - Fixed a few bugs here and there.
Fixed some loading bugs on `app/control-center.html`, `app/staff.html` and `app/settings.html` and made all work at the first load.
Added new parateter `obj.Team.{Home|Away}.Short` to `app/json/data.json` to display the short name of the team. Influencing changes:
- Changed the displayed name on `app/scoreboard.html` and `app/innings.html` from `obj.Team.{Home|Away}.Name` to `obj.Team.{Home|Away}.Short`. Making it more readable and professional.
- Added field `Short Name` to `app/control-center.html` between `Name` and `Color` to set the short name of the team. Limited to 3 characters.
- Eddited default values of `app/json/data.json` and changed reset default on `socket.js` and `updateData.js`
…faut value Edit of `Reset_All` function and added the new data defaut value on the `app/json/data.json` file
Increased maximum message size to 15MB. So 2 5MB images are accepted and the headers are includes. Issue found by @TheTecnoKing yesterday
- Added a new "Custom scaling" option in the streaming resolution setting. Currently disabled, will be enabled later on when this feature has had more work done to it - Changed color scheme for the "Blacken last inning" toggle - Made the "Add new user" area take up less space by moving and changing the "Add user" button - Redid the first panel's layout, with items now "squeezed" against each other to take all the available horizontal space between breakpoints
Added the possibility to update the scoreboard according the official box score from the official federation website. For working you must provide the brodcasting ID founded on the URL of the box-score when live. (Tested only with FIBS games)
Addded WSBC data override controls on `settings.html` page (to be rewieved @TheTecnoKing) Added new field on `app/json/settings.json` for the toggle and the gameID taken from WSBC. Tested all the code with varius WSBC games from different situations and it works fine. (network required)
- Added a new "Custom scaling" option in the streaming resolution setting. Currently not working, will be used later on when this feature has had more work done to it - Changed color scheme for the "Blacken last inning" toggle - Made the "Add new user" area take up less space by moving and changing the "Add user" button - Redid the first panel's layout, with items now "squeezed" against each other to take all the available horizontal space between breakpoints - Differentiated between full names and short names in control-center.html - Updated the username's breakpoints in all.js - You can use "Enter" to add users in settings.html instead of being forced to use the dedicated button
Reverted a change done to all.js in the latest commit
Live Updates from WBSC (MyBallClub)
Adjusted footer on all pages Co-authored-by: TheTecnoKing <75082274+TheTecnoKing@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logo Support
In this PR we add the logo support for the team's logo, it could be any image file type.
The image will be re-factored to a cropped 1:1 focused on the centre if the ratio is different than a 1:1
Edited the
control-center.htmlto support uploading the logo, remotion and a small preview.Short Name introduced
Added a new parameter
Short Namea short version of the team name used on thescoreboard.htmlandinning.htmlscoreboards. This short name has a limitation of 3 characters.Edited the
control-center.htmlto support one more inputWBSC update added
Added the WBSC data override to synchronize your overlay with the official situation. #54