Add rpm bugfix bump 8.3.0 --> 8.3.1 #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjbreaux
reviewed
May 12, 2017
f5_openstack_agent/__init__.py
Outdated
| @@ -1 +1 @@ | |||
| __version__ = "8.3.0" | |||
| __version__ = "8.3.1" | |||
There was a problem hiding this comment.
Can you change the version to 8.3.1.b1
Issues: Fixes #663 Problem: An sdk issue was preventing RPM installs. Analysis: See the SDK issue: F5Networks/f5-common-python#1116 Tests: "SAP" tests were run manually in my bbot-sandbox.
|
Once we finish running tests against this code, I will approve. |
szakeri
approved these changes
May 12, 2017
|
Ran the tests and the results look good. Merging. |
|
+1 |
zhang-shengping
pushed a commit
to zhang-shengping/f5-openstack-agent
that referenced
this pull request
Feb 27, 2019
Issues: Fixes F5Networks#710 Problem: Nightly TRTL results accumulated extra results because of a failure to remove directories from the NFS file system. Analysis: In order to enable the docker testrunner "jenkins" user to write to the -v mounted volume it shared with the executor I added "sudo -E" commands to the systest scripts. This worked by allowing the write operations but caused a subsequent bug, the executor could not remove the sudo-written files. One fix might be to cause the openstack-test-testrunner container to be _RUN_ by the "jenkins" user, but the openstack team does not control that interface. As a workaround the "jenkins" user _inside_ the testrunner container, chowns the relevant directory structure at the start of its test run. Changes: * Remove sudo -E, depend on chown -R in Makefile * remove .PHONY directive, and modify chown directive Tests: This commit was validated by this test run: http://jenkins.pdbld.f5net.com/job/openstack/job/driver/job/mitaka/job/za_test_11.6.1_undercloud_vxlan/4/
zhang-shengping
pushed a commit
to zhang-shengping/f5-openstack-agent
that referenced
this pull request
Feb 27, 2019
zhang-shengping
pushed a commit
to zhang-shengping/f5-openstack-agent
that referenced
this pull request
Feb 27, 2019
Issues: Fixes F5Networks#710 Problem: Nightly TRTL results accumulated extra results because of a failure to remove directories from the NFS file system. Analysis: In order to enable the docker testrunner "jenkins" user to write to the -v mounted volume it shared with the executor I added "sudo -E" commands to the systest scripts. This worked by allowing the write operations but caused a subsequent bug, the executor could not remove the sudo-written files. One fix might be to cause the openstack-test-testrunner container to be _RUN_ by the "jenkins" user, but the openstack team does not control that interface. As a workaround the "jenkins" user _inside_ the testrunner container, chowns the relevant directory structure at the start of its test run. Changes: * Remove sudo -E, depend on chown -R in Makefile * remove .PHONY directive, and modify chown directive Tests: This commit was validated by this test run: http://jenkins.pdbld.f5net.com/job/openstack/job/driver/job/mitaka/job/za_test_11.6.1_undercloud_vxlan/4/
zhang-shengping
pushed a commit
to zhang-shengping/f5-openstack-agent
that referenced
this pull request
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Fixes #663
Problem: An sdk issue was preventing RPM installs.
Analysis: See the SDK issue:
F5Networks/f5-common-python#1116
Tests: "SAP" tests were run manually in my bbot-sandbox.