Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

# Update functional tests to reference mgmt_root instead of bigip #1335

Merged

Conversation

jasonrahm
Copy link

Issues:
Fixes #1334

Problem: Many old tests still reference the bigip object.

Analysis: Refactored all functional tests that use the bigip object to use the mgmt_root object instead

@caphrim007
Copy link
Contributor

Can't set status; build failed.

2 similar comments
@caphrim007
Copy link
Contributor

Can't set status; build failed.

@caphrim007
Copy link
Contributor

Can't set status; build failed.

@caphrim007
Copy link
Contributor

Can't set status; build succeeded.

@jasonrahm
Copy link
Author

i'll squash commits and resubmit shortly

@jasonrahm jasonrahm force-pushed the cleanup.tests_with_BigIP branch from 58a4af2 to 63077ea Compare December 4, 2017 23:07
Fixes F5Networks#1334

Problem: Many old tests still reference the bigip object.

Analysis: Refactored all functional tests that use the bigip object to use the mgmt_root object instead
@caphrim007
Copy link
Contributor

Can't set status; build succeeded.

@jasonrahm
Copy link
Author

ready for review, @caphrim007 or @wojtek0806

@caphrim007
Copy link
Contributor

lgtm

@caphrim007 caphrim007 merged commit 5c9af31 into F5Networks:development Dec 4, 2017
@jasonrahm jasonrahm deleted the cleanup.tests_with_BigIP branch December 4, 2017 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants