Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues: 1116, bugfix release #1130

Merged
merged 1 commit into from
May 12, 2017
Merged

Issues: 1116, bugfix release #1130

merged 1 commit into from
May 12, 2017

Conversation

zancas
Copy link
Contributor

@zancas zancas commented May 12, 2017

Fixes #1116

Problem:
This issue is a few fold:

  1. RPM spec file format was not being followed properly
  • Requires: , [repeat]
  1. RPM was not actually installing dependencies during test
  2. RPM was not failing when project package failed to install during test
  3. DEB was not actually installing dependencies during test
  4. DEB was not fialing when project package failed to install during test

Analysis:

  1. added a check_requires() function that will add the proper formatting
  • Change performed in the build-rpm.py
  1. Changed the Dependency.cmd to be handled differently with a
    Dependency.install_cmd
  • Change performed in the redhat's fetch_and_install_deps.py
  1. Fix was multi-fold, but all under redhat's fetch_and_install_deps.py:
  • runCommand() was changed to use subprocess.check_output
  • runCommand()'s call for rpm -i now has a status check
  • a last verification against rpm -qa is performed
  1. Made a Dependency._install_req to be cond. exec. by parent
  • This is always executed by F5Dependency
  • This is added to the ubuntu's fetch_and_install_deps.py
  1. Again multi-fold in the ubuntu's fetch_and_install_deps.py:
  • runCommand() was changed to use subprocess.check_output
  • runCommand()'s call for dpkg -i now has a status check
  • a last verification against dpkg -l is performed

Tests:
This is a test in and of itself; however, there is now an additional
ring of tests for both ubuntu and debian that assures, using its
individual packaging medium, a means to verify that the package is, in
fact, installed after the processing of the test scripts on the
associated docker container instance.

@pjbreaux
Copy link
Contributor

No bump of init.py in here?

@zancas
Copy link
Contributor Author

zancas commented May 12, 2017

@pjbreaux not yet.

@zancas
Copy link
Contributor Author

zancas commented May 12, 2017

@caphrim007 @pjbreaux can we get this approved and merged please?

@caphrim007
Copy link
Contributor

lgtm

@pjbreaux
Copy link
Contributor

Bump the version, and we'll merge.

Fixes #1116

Problem:
This issue is a few fold:
1. RPM spec file format was not being followed properly
  * Requires: <module> <modifier> <version>, [repeat]
2. RPM was not actually installing dependencies during test
3. RPM was not failing when project package failed to install during test
4. DEB was not actually installing dependencies during test
5. DEB was not fialing when project package failed to install during test

Analysis:
1. added a check_requires() function that will add the proper formatting
  * Change performed in the build-rpm.py
2. Changed the Dependency.cmd to be handled differently with a
Dependency.install_cmd
  * Change performed in the redhat's fetch_and_install_deps.py
3. Fix was multi-fold, but all under redhat's fetch_and_install_deps.py:
  * runCommand() was changed to use subprocess.check_output
  * runCommand()'s call for rpm -i <project> now has a status check
  * a last verification against rpm -qa is performed
4. Made a Dependency._install_req to be cond. exec. by parent
  * This is always executed by F5Dependency
  * This is added to the ubuntu's fetch_and_install_deps.py
5. Again multi-fold in the ubuntu's fetch_and_install_deps.py:
  * runCommand() was changed to use subprocess.check_output
  * runCommand()'s call for dpkg -i <project> now has a status check
  * a last verification against dpkg -l is performed

Tests:
This is a test in and of itself; however, there is now an additional
ring of tests for both ubuntu and debian that assures, using its
individual packaging medium, a means to verify that the package is, in
fact, installed after the processing of the test scripts on the
associated docker container instance.
@pjbreaux pjbreaux removed the request for review from ssorenso May 12, 2017 19:08
Copy link
Contributor

@pjbreaux pjbreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@pjbreaux pjbreaux self-assigned this May 12, 2017
@pjbreaux pjbreaux merged commit febd84c into F5Networks:2.3-stable May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants