Issues: #1116 - Multi-step fix for RPM and DEB package validation #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3fd2219 to
bff5816
Compare
ssorenso
commented
Apr 14, 2017
| match = breakout_re.search(requirement) | ||
| if match: | ||
| req = Req(*match.groups()) | ||
| mod = 'python-' + req.module \ |
There was a problem hiding this comment.
Is it safe to assume that we'll always use a library with python- pre-appended.
There was a problem hiding this comment.
Yes, this is the pattern followed by RHEL. If we are depending on python libs outside of the set of RHEL supported packages, the we have to ask "Do we really need them?"
ssorenso
commented
Apr 14, 2017
| runCommand('rpm -i %s' % tmp_pkg_name) | ||
| output, result = runCommand('rpm -i %s 2>&1' % tmp_pkg_name) | ||
| if not result == 0: | ||
| raise InstallError("Exist status was {}".format(result)) |
bff5816 to
f508d9f
Compare
ssorenso
commented
Apr 19, 2017
| @@ -447,7 +454,12 @@ def fetch_pkg_dependencies(config, pkg_name): | |||
|
|
|||
| print("Installing Self - %s" % pkg_name) | |||
| try: | |||
| runCommand('dpkg -i %s' % tmp_pkg_name) | |||
| output, result = runCommand('dpkg -l | grep f5-') | |||
Fixes F5Networks#1116 Problem: This issue is a few fold: 1. RPM spec file format was not being followed properly * Requires: <module> <modifier> <version>, [repeat] 2. RPM was not actually installing dependencies during test 3. RPM was not failing when project package failed to install during test 4. DEB was not actually installing dependencies during test 5. DEB was not fialing when project package failed to install during test Analysis: 1. added a check_requires() function that will add the proper formatting * Change performed in the build-rpm.py 2. Changed the Dependency.cmd to be handled differently with a Dependency.install_cmd * Change performed in the redhat's fetch_and_install_deps.py 3. Fix was multi-fold, but all under redhat's fetch_and_install_deps.py: * runCommand() was changed to use subprocess.check_output * runCommand()'s call for rpm -i <project> now has a status check * a last verification against rpm -qa is performed 4. Made a Dependency._install_req to be cond. exec. by parent * This is always executed by F5Dependency * This is added to the ubuntu's fetch_and_install_deps.py 5. Again multi-fold in the ubuntu's fetch_and_install_deps.py: * runCommand() was changed to use subprocess.check_output * runCommand()'s call for dpkg -i <project> now has a status check * a last verification against dpkg -l is performed Tests: This is a test in and of itself; however, there is now an additional ring of tests for both ubuntu and debian that assures, using its individual packaging medium, a means to verify that the package is, in fact, installed after the processing of the test scripts on the associated docker container instance.
f508d9f to
82c2f47
Compare
pjbreaux
approved these changes
Apr 25, 2017
|
@richbrowne, any chance of a check for this? Just trying to clean up the dots on my radar screen... Thanks |
richbrowne
approved these changes
Apr 28, 2017
|
seeing this was approved i am merging this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1116
Problem:
This issue is a few fold:
Analysis:
Dependency.install_cmd
Tests:
This is a test in and of itself; however, there is now an additional
ring of tests for both ubuntu and debian that assures, using its
individual packaging medium, a means to verify that the package is, in
fact, installed after the processing of the test scripts on the
associated docker container instance.
Assignee:
@pjbreaux
Reviewers:
@richbrowne