Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Members modify() broken when setting session attribute #1137

Closed
jlongstaf opened this issue May 23, 2017 · 0 comments
Closed

Members modify() broken when setting session attribute #1137

jlongstaf opened this issue May 23, 2017 · 0 comments

Comments

@jlongstaf
Copy link
Contributor

The modify command incorrectly checks value of "state" attribute when "session" attribute is passed in modify(). See line 217 in pool.py:

if 'session' in patch: if patch['session'] != 'user-enabled' and patch['state'] != \ 'user-disabled':

patch['state'] should be patch['session']

This is causing an error in the F5 OpenStack agent when users try to set admin state up/down for a pool member.

jlongstaf added a commit to jlongstaf/f5-common-python that referenced this issue May 23, 2017
Issues:
Fixes F5Networks#1137

Problem: Member modify incorrectly checks value of 'state' attribute
when user passes 'session' attribute to modify.

Analysis: patch['state'] is not correct. should be patch['session']

Tests: Added new test, test_session_modify(), to match existing test
test_state_modify().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant