-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowed null
Namespace for Framework Types
#430
Allowed null
Namespace for Framework Types
#430
Conversation
Wow interesting. Thank you for reporting this, @oliver-chime and for the commit. Can you verify that the version this occurred in was prior to The check for the However, the bigger problem it would seem is that for some reason the provided |
The issue occurred with version |
✅ Build ExtendedXmlSerializer 3.2.5.1-hnmaclnq completed (commit 14c4b9d884 by @Mike-E-angelo) Install it by running the following command in Package Manager Console:
|
Alright @oliver-chime I was able to get that committed. Please try the above package on our preview feed and see if that treats you better. If this is not feasible (since this problem is a production-only issue), please let me know if the committed file works for you and I will accept it into mainline.
Thank you for clarifying this, btw. I was worried that we somehow introduced another problem with #424 -- another |
Thanks for the quick response @Mike-E-angelo. Regarding your changes: Shouldn't the condition look like this: |
Indeed @oliver-chime I threw you a curveball. 😁 Somewhere between my suggested condition and my commit I realized that we do not want any type with a I just now created a simple project and it does seem to fail on null namespaces: However, that is for custom assemblies and not where the condition is probing, which is in the |
null
Namespace
✅ Build ExtendedXmlSerializer 3.2.5.1-wyovnhhb completed (commit 0ee3ab6fcd by @Mike-E-angelo) Install it by running the following command in Package Manager Console:
|
Thanks @Mike-E-angelo , will get back to you once I can verify the change. |
null
Namespacenull
Namespace for Framework Types
Going to get this deployed to NuGet. Please let me know if you encounter any further issues with it and we'll take it from there. 👍 |
Cool, FWIW got you in the release notes, @oliver-chime: https://github.com/ExtendedXmlSerializer/home/releases/tag/v3.2.6 This has also been deployed to NuGet: https://www.nuget.org/packages/ExtendedXmlSerializer/
|
Thanks @Mike-E-angelo. I can confirm the change solved our issue on production. |
Awesome, good to hear, @oliver-chime! Thanks for the update. 👍 |
This is a fix for a critical issue we recently experienced with a .NET Core app running in a production environment where deserilization calls started returning exceptions at seemingly random intervals.
The issue began occurring without any changes to how the serializer is handled or the structure of the objects being serialized. We were not able to reproduce this issue outside of production.
Below is an example of the exceptions we were seeing: