-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests/setup #17
Open
ff6347
wants to merge
13
commits into
master
Choose a base branch
from
tests/setup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+192
−1
Open
Tests/setup #17
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
8fa1073
Assertion functions
4743258
allow launch.json for vscode
12336d4
allow vscode settings
a9f0552
add test section
ab8050c
adds tests to test test functions
17c7091
Added filter, forEach tests, and toEqualArray assertion
lumenn fce5439
Added indexOf test
lumenn 2cb2f5b
Added tests for isArray, lastIndexOf, map
lumenn 3b5abd5
Added reduce test
lumenn de24589
Added reduceRight test
lumenn 54080cc
Added some tests
lumenn b1e9d76
Checked also inside InDesign, and rolled back to InDesign as standard…
lumenn c3eacc3
test setup stashing
ff6347 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this function taken from jest source?
Would be good if we not introduce new functions. This would allow to use jest on the CI server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's one i wrote.
Current functions don't allow to compare arrays, so that's how this one ended up here.
We should only stick to those 4 functions we already have?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. My master plan is to write only functions jest also understands. So we can have tests running on Adobe products and also on CI server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://repl.it/repls/NormalEmptyClicks
It seems that we should correct our implementation of toEqual, as in jest it can easily compare arrays. Testing our implementation in InDesign doesn't pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally. I just hacked that together. Really needs some love. :) Maybe I'll find some space at the weekend for it