Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests action #14

Merged
merged 1 commit into from
Oct 27, 2019
Merged

add tests action #14

merged 1 commit into from
Oct 27, 2019

Conversation

ff6347
Copy link
Member

@ff6347 ff6347 commented Oct 26, 2019

No description provided.

@ff6347
Copy link
Member Author

ff6347 commented Oct 26, 2019

@lumenn Do you have an idea for a good automated test for these?
Maybe removing all the existing functions and patching them with a shim?
Once we have this going we can make a new release and it should be pushed to the registry once we merge #13

@lumenn
Copy link
Member

lumenn commented Oct 27, 2019

Which functions would you remove ?
Never wrote any automated js tests before, thats some field i still have to learn.

For sure tests should be run on a real Adobe products, as ExtendScript has it's own things that JS does not.

If you could give me some points what could i check to get it working i'll be glad to work on those :)

@ff6347
Copy link
Member Author

ff6347 commented Oct 27, 2019

Well. Well won’t get a CI Server with an ExtendScript engine. That’s why I would set all functions we patch to undefined and let them use our shims.

I’ll try to write a test for it.

@ff6347 ff6347 merged commit 1205de2 into master Oct 27, 2019
@ff6347 ff6347 deleted the ci/tests-action branch October 27, 2019 19:22
@lumenn
Copy link
Member

lumenn commented Oct 29, 2019

Seems like a good idea to me then.
Currently checking examples you've prepared, i'll try to work on it, been off for weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants