Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid issuer error during incoming request verification if the bot host contains url parts other than the domain #460

Merged

Conversation

alexhook
Copy link
Member

@alexhook alexhook commented Mar 24, 2024

PR checklist

  • I've written good commit message for all commits
  • I've split changes into separate commits where it's appropriate
  • I've added the description of function to documentation
  • I've updated project version in pyproject.toml
  • I'll make a release when PR is merged
  • I'll bump pybotx in bot-template

@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e6d0795) to head (426acd0).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #460   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          116       116           
  Lines         3942      3950    +8     
  Branches       347       348    +1     
=========================================
+ Hits          3942      3950    +8     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexhook alexhook force-pushed the fix/verify_request_error_while_bot_host_contains_path branch from 68f454b to 4e87290 Compare March 24, 2024 20:30
@alexhook alexhook force-pushed the fix/verify_request_error_while_bot_host_contains_path branch 2 times, most recently from fc78a2d to 6d7230d Compare March 25, 2024 12:01
@alexhook alexhook force-pushed the fix/verify_request_error_while_bot_host_contains_path branch from 6d7230d to 426acd0 Compare March 25, 2024 12:57
… bot host contains url parts other than the domain
@alexhook alexhook force-pushed the fix/verify_request_error_while_bot_host_contains_path branch from 426acd0 to fbc6729 Compare March 25, 2024 21:29
@alexhook alexhook merged commit 8703175 into master Mar 26, 2024
7 checks passed
@alexhook alexhook deleted the fix/verify_request_error_while_bot_host_contains_path branch March 26, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants