forked from necolas/react-native-web
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: [Violation] Added non-passive event listener to a scroll-blocking 'wheel' event #24
Closed
tienifr
wants to merge
9
commits into
Expensify:master
from
tienifr:fix/warning-non-passive-event-listener
Closed
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ee4f856
fix: warning: Added non-passive event listener to a scroll-blocking '…
tienifr 8fe25cc
do not export canUsePassive
tienifr a92d847
fix lint
tienifr a09bf66
restore index.js
tienifr a334af2
add passive option to removeListener instead
tienifr f10b647
passive options
tienifr 70adc32
remove preventDefault
tienifr 73c7126
add comment
tienifr 8272ccb
update comment
tienifr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
22 changes: 22 additions & 0 deletions
22
packages/react-native-web/src/modules/canUsePassive/index.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
/** | ||
* Allows us to identify whether the browser supports passive event listener. | ||
* Because older browsers will interpret any object in the 3rd argument of an event listener as capture=true. | ||
* | ||
* @returns {Boolean} | ||
*/ | ||
|
||
export default function canUsePassive() { | ||
let supportsPassive = false; | ||
try { | ||
const opts = Object.defineProperty({}, 'passive', { | ||
// eslint-disable-next-line getter-return | ||
get() { | ||
supportsPassive = true; | ||
} | ||
}); | ||
window.addEventListener('testPassive', null, opts); | ||
window.removeEventListener('testPassive', null, opts); | ||
// eslint-disable-next-line no-empty | ||
} catch (e) {} | ||
return supportsPassive; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAB: Don't think this line is necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!