Support React Native 0.77 #600
Conversation
| @@ -132,6 +134,13 @@ android { | |||
| } else { | |||
| java.srcDirs += ["src/oldarch"] | |||
| } | |||
|
|
|||
| // TextLayoutManager | |||
There was a problem hiding this comment.
This is not very informative
There was a problem hiding this comment.
...sionPatch/CustomMountingManager/latest/com/expensify/livemarkdown/CustomMountingManager.java
Outdated
Show resolved
Hide resolved
...sionPatch/CustomMountingManager/latest/com/expensify/livemarkdown/CustomMountingManager.java
Show resolved
Hide resolved
|
I'm getting the following error when trying to build a fresh RN 0.77.0 app for Android on Paper: 
|
|
@tomekzaw I am confused since this method accepts 3 arguments: https://github.com/facebook/react-native/blob/v0.77.0/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/TextLayoutManager.java#L184 and I am giving it 3 arguments: https://github.com/Expensify/react-native-live-markdown/pull/600/files#diff-3557d72e0be2d776fa6982a4f9760a95bcccbedd06e9bbd363707b9d8e8ad83aR109 |
|
Incorrect component height on Android, 0.77.0, New Arch enabled
@j-piasecki said it's probably caused by incorrect order of commit hooks (Markdown & Reanimated). |
src/MarkdownTextInput.web.tsx
Outdated
| fontFamily: 'sans-serif', | ||
| // @ts-expect-error it works on web | ||
| boxSizing: 'border-box', | ||
| // @ts-expect-error some type changes | ||
| overflowY: 'auto', |
There was a problem hiding this comment.
cc @Skalakid What do you think about these changes?
There was a problem hiding this comment.
lgtm for me, but how about changing the comment description to something more clear. We can leave it works on web like it was previously
cc @WoLewicki @tomekzaw
There was a problem hiding this comment.
Ok I changed it like you suggested @Skalakid .
|
Tested on the example app with RN 0.77, looks good to me. Layout works correctly on first render as well as during typing both on Android and iOS. |
|
So are we ready to merge it? |
Details
PR aligning library with RN 0.77
Related Issues
Commits from RN changing methods used by this library: facebook/react-native@08e8f6a, facebook/react-native@060c594#diff-e53011726a0eaf0dd8acab115a5e380e2b6d5e5e7504e1825bbce8418c1c91cb
Manual Tests
Linked PRs