Replace the commit hook with a wrapper component based on display: contents
#566
+569
−1,129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-piasecki
commented
Dec 6, 2024
Comment on lines
78
to
79
| const auto &mutableChild = | ||
| std::const_pointer_cast<TextInputShadowNode>(child); |
There was a problem hiding this comment.
The logic here (not specifically these lines, in general) assumes that if the decorator node is mutable, the child text input is also mutable. I'm not actually sure whether this assumption always holds true.
It may make sense to check the children in the constructor and clone them if fragment.children is null and the children list is not empty to ensure the child is mutable.
There was a problem hiding this comment.
This should be fine? Rerendering the decorator node should also rerender the text input underneath.
0edb26e to
26f8433
Compare
This was referenced Mar 7, 2025
tomekzaw
reviewed
Mar 11, 2025
android/src/main/java/com/expensify/livemarkdown/LiveMarkdownModule.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/expensify/livemarkdown/MarkdownTextInputDecoratorViewManagerSpec.java
Show resolved
Hide resolved
...w_arch/react/renderer/components/RNLiveMarkdownSpec/MarkdownTextInputDecoratorShadowNode.cpp
Outdated
Show resolved
Hide resolved
...w_arch/react/renderer/components/RNLiveMarkdownSpec/MarkdownTextInputDecoratorShadowNode.cpp
Outdated
Show resolved
Hide resolved
…downSpec/MarkdownTextInputDecoratorShadowNode.cpp Co-authored-by: Tomek Zawadzki <tomekzawadzki98@gmail.com>
tomekzaw
reviewed
Mar 12, 2025
tomekzaw
reviewed
Mar 12, 2025
...w_arch/react/renderer/components/RNLiveMarkdownSpec/MarkdownTextInputDecoratorShadowNode.cpp
Outdated
Show resolved
Hide resolved
...w_arch/react/renderer/components/RNLiveMarkdownSpec/MarkdownTextInputDecoratorShadowNode.cpp
Outdated
Show resolved
Hide resolved
...w_arch/react/renderer/components/RNLiveMarkdownSpec/MarkdownTextInputDecoratorShadowNode.cpp
Outdated
Show resolved
Hide resolved
...w_arch/react/renderer/components/RNLiveMarkdownSpec/MarkdownTextInputDecoratorShadowNode.cpp
Outdated
Show resolved
Hide resolved
...w_arch/react/renderer/components/RNLiveMarkdownSpec/MarkdownTextInputDecoratorShadowNode.cpp
Outdated
Show resolved
Hide resolved
Comment on lines
+68
to
+76
| const auto &children = getChildren(); | ||
| react_native_assert( | ||
| children.size() == 1 && | ||
| "MarkdownTextInputDecoratorView received wrong number of children"); | ||
|
|
||
| const auto child = | ||
| std::static_pointer_cast<const TextInputShadowNode>(children.at(0)); | ||
|
|
||
| child->ensureUnsealed(); |
There was a problem hiding this comment.
Let's move this common logic to a utility function called something like getMutableTextInputShadowNodeFromChildren but in a separate PR
| // apply markdown formatting before measuring the child | ||
| const auto &mutableChild = | ||
| std::const_pointer_cast<TextInputShadowNode>(child); | ||
| applyMarkdown(mutableChild, layoutContext); |
There was a problem hiding this comment.
TODO: rename applyMarkdown so it explicitly says what it does under the hood
There was a problem hiding this comment.
Is applyMarkdownStylesToTextInputState ok?
Comment on lines
+135
to
+140
| // this can possibly be optimized | ||
| RCTMarkdownStyle *markdownStyle = | ||
| [[RCTMarkdownStyle alloc] initWithStruct:markdownProps.markdownStyle]; | ||
| RCTMarkdownUtils *utils = [[RCTMarkdownUtils alloc] init]; | ||
| [utils setMarkdownStyle:markdownStyle]; | ||
| [utils setParserId:[NSNumber numberWithInt:markdownProps.parserId]]; |
There was a problem hiding this comment.
TODO: store this somewhere pretty please in a separate PR
Co-authored-by: Tomek Zawadzki <tomekzawadzki98@gmail.com>
…downSpec/MarkdownTextInputDecoratorShadowNode.cpp Co-authored-by: Tomek Zawadzki <tomekzawadzki98@gmail.com>
…downSpec/MarkdownTextInputDecoratorShadowNode.cpp Co-authored-by: Tomek Zawadzki <tomekzawadzki98@gmail.com>
Co-authored-by: Tomek Zawadzki <tomekzawadzki98@gmail.com>
tomekzaw
reviewed
Mar 12, 2025
...w_arch/react/renderer/components/RNLiveMarkdownSpec/MarkdownTextInputDecoratorShadowNode.cpp
Outdated
Show resolved
Hide resolved
…downSpec/MarkdownTextInputDecoratorShadowNode.cpp Co-authored-by: Tomek Zawadzki <tomekzawadzki98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
React Native 0.77 comes with support for
display: contentswhich would allow to make a wrapper component that doesn't impact layout in any way. This can be used to replace the commit hook to apply markdown styles without cloning the tree.Related Issues
GH_LINK
Manual Tests
Linked PRs