Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary focus on the Add payment method button #9348

Merged
merged 10 commits into from
Jun 14, 2022
Merged

Unnecessary focus on the Add payment method button #9348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bccaf3a
fix: remove un-necessasry focus
allroundexperts Jun 3, 2022
b843fea
menu item blur
allroundexperts Jun 6, 2022
1330f09
Merge branch 'main' into fix-9248
allroundexperts Jun 7, 2022
fd800e2
Update Button.js
allroundexperts Jun 13, 2022
04af39c
Update MenuItem.js
allroundexperts Jun 13, 2022
7aaa512
Update Button.js
allroundexperts Jun 13, 2022
4266cf4
Update MenuItem.js
allroundexperts Jun 13, 2022
260c699
fixed lint errors
allroundexperts Jun 13, 2022
5968665
preferred way for type check
allroundexperts Jun 13, 2022
c31b789
more comments handled
allroundexperts Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/components/Button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,10 @@ class Button extends Component {
return (
<Pressable
onPress={(e) => {
if (e && e.type === 'click') {
e.currentTarget.blur();
}

if (this.props.shouldEnableHapticFeedback) {
HapticFeedback.trigger();
}
Expand Down
4 changes: 4 additions & 0 deletions src/components/MenuItem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ const MenuItem = props => (
return;
}

if (e && e.type === 'click') {
e.currentTarget.blur();
}

props.onPress(e);
}}
style={({hovered, pressed}) => ([
Expand Down