-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get latest archive reason in workspace chat after policy members are removed #9262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atest archive reason
MariaHCD
approved these changes
Jun 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
27 tasks
2 similar comments
This was referenced Jun 3, 2022
Closed
🚀 Deployed to production by @yuwenmemon in version: 1.1.71-2 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
The reason the original issue happens (specifically in this comment in the original issue) is because we are fetching the latest state of the report, but we are not fetching the actions so we don't see the closed action. When navigating away from the report and back, we refetch the report actions in ReportActions view here and that's why it shows up in that case.
Another quirk with this. After you add and then remove a member from a workspace the first time, it shows this bug where the archive reason doesn't appear in the chat. However, if you add and then remove that same member afterwards, it appears as if the archive reason instantly updates.
What's actually happening is that the archive reason is stored in the
CLOSED
type report action and since there was already aCLOSED
report action on this workspace chat before, we fall back to that until we navigate out of the chat and back. Without the code change in this PR, you can test this locally. If you can look at thereportActions_<reportID>
in Onyx and see that a newCLOSED
action doesn't get added after you remove a member. It add anotherCLOSED
action until you navigate out of the chat and back.TL;DR: As, soon as we see the
policyEmployeeRemoved
pusher action and fetch the policyExpenseChats again (to get their archived state), we'll also fetch their actions (to get the latest archive reason).Fixed Issues
$ #8644
Tests
Same as WebQA done locally
PR Review Checklist
Contributor (PR Author) Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesSTYLE.md
) were followed/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)QA Steps
Test this on staging
Screenshots
Web