Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate API #9127

Merged
merged 1 commit into from
May 24, 2022
Merged

Deprecate API #9127

merged 1 commit into from
May 24, 2022

Conversation

nkuoch
Copy link
Contributor

@nkuoch nkuoch commented May 23, 2022 •
edited
Loading

Fixed Issues

Part of https://github.com/Expensify/Expensify/issues/211230

Tests

Non regression tests - Made sure the main features still worked.

  • Creating a chat
  • Creating a bank account
  • Creating a debit card
  • Changing language
  • Changing names
  • Asking for money
  • Creating workspace
  • ...

QA Steps

Existing non regression tests are enough.

Screenshots

Web

image

@nkuoch nkuoch requested review from marcaaron and a team as code owners May 23, 2022 08:01
@nkuoch nkuoch self-assigned this May 23, 2022
@melvin-bot melvin-bot bot requested review from mountiny and removed request for a team May 23, 2022 08:02
@nkuoch nkuoch marked this pull request as draft May 23, 2022 08:02
@nkuoch nkuoch removed request for marcaaron and mountiny May 23, 2022 08:02
@nkuoch nkuoch marked this pull request as ready for review May 23, 2022 09:09
@nkuoch nkuoch requested review from marcaaron and a team May 23, 2022 09:09
@melvin-bot melvin-bot bot requested review from mountiny and removed request for a team May 23, 2022 09:09
mountiny
mountiny approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I could not find anywhere we would omit to update the API and I believe the linter or complier would scream if there would be some mismatch/reference to a file which does not exist anymore.

@marcaaron marcaaron removed their request for review May 23, 2022 16:22
@nkuoch nkuoch merged commit 9f836c6 into main May 24, 2022
@nkuoch nkuoch deleted the nat-deprecatedAPI branch May 24, 2022 12:13
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request May 24, 2022
Closed
26 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @nkuoch in version: 1.1.66-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.66-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@SumitDiyora SumitDiyora mentioned this pull request May 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldoglas danieldoglas danieldoglas approved these changes

@mountiny mountiny mountiny approved these changes

Assignees

@nkuoch nkuoch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nkuoch @OSBotify @danieldoglas @mountiny