[NoQA] Fix the new contributor message #8542
Conversation
| - name: Check whether the actor is member of Expensify/expensify team | ||
| id: checkActor | ||
| uses: tspascoal/get-user-teams-membership@baf2e6adf4c3b897bd65a7e3184305c165aec872 | ||
| with: | ||
| GITHUB_TOKEN: ${{ secrets.OS_BOTIFY_TOKEN }} | ||
| username: ${{ github.actor }} |
There was a problem hiding this comment.
The github.actor is the person who merges the PR unfortunately, so we need to use the action-get-merged-pull-request to get info about the PR.
|
I might be able to re-run this job https://github.com/Expensify/App/runs/5869232353?check_suite_focus=true once this is merged to test the PR. |
|
Thank you @madmax330 🙇 |
|
Confirmed it worked by checking the action for this PR merge, the username should be mine (mountiny) as the creator of the PR and not of Maxence. All good 👍
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @madmax330 in version: 1.1.54-0 🚀
|
|
🚀 Deployed to production by @Julesssss in version: 1.1.54-1 🚀
|
Details
The functionality is broken currently as seen here, and I am working on a refactoring of the predeploy, but cant fit it into my schedule currently as testing takes a long time.
The problem is that the
isExpensifyEmployeetakes the username of the person who merged the code and not the owner of the PR.Fixed Issues
This is related to https://github.com/Expensify/Expensify/issues/194440
Tests
QA Steps
See whether a PR from a new contributor gets a welcome message.