Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Add NewDot deployer responsibilities #8518

Merged
merged 3 commits into from
Apr 7, 2022
Merged

[No QA] Add NewDot deployer responsibilities #8518

merged 3 commits into from
Apr 7, 2022

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Apr 6, 2022 •
edited
Loading

Details

Add a couple new checkboxes to the StagingDeployCash to add some extra NewDot deployer responsibilites.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/203091 https://github.com/Expensify/Expensify/issues/203088

Tests

  1. CP this pull request (if deploy checklist is locked). Otherwise just merge it without CP label.
  2. The StagingDeployCash should get the new checklist items.
  3. Check off the new items.
  4. CP another pull request.
  5. The items should be unchecked.
  6. Check off the items again.
  7. Mark an issue as a deploy blocker.
  8. The items should remain checked.

@roryabraham roryabraham changed the title Update checkDeployBlockers to look for any open checkbox except acces… Add NewDot deployer responsibilities Apr 6, 2022
@roryabraham roryabraham changed the title Add NewDot deployer responsibilities [No QA] Add NewDot deployer responsibilities Apr 6, 2022
@roryabraham roryabraham marked this pull request as ready for review April 6, 2022 22:04
@roryabraham roryabraham requested a review from a team as a code owner April 6, 2022 22:04
@roryabraham roryabraham self-assigned this Apr 6, 2022
@melvin-bot melvin-bot bot requested review from deetergp and removed request for a team April 6, 2022 22:04
deetergp
deetergp requested changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@deetergp deetergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had one minor comment, but otherwise looks good to me.

@deetergp deetergp merged commit a6e42b9 into main Apr 7, 2022
@deetergp deetergp deleted the Rory-AddNewDotDeployerChores branch April 7, 2022 23:06
@OSBotify
Copy link
Contributor

OSBotify commented Apr 7, 2022

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@roryabraham roryabraham mentioned this pull request Apr 8, 2022
Closed
17 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Apr 8, 2022

🚀 Deployed to staging by @deetergp in version: 1.1.54-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Julesssss in version: 1.1.54-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deetergp deetergp deetergp approved these changes

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roryabraham @OSBotify @deetergp